Exclude backingStore.etcd's image from getting populated when disabled #2411
Conversation
Signed-off-by: abhay.tomar <[email protected]>
| // build values | ||
| if apiImage != "" { | ||
| vConfig.ControlPlane.Distro.K8S.Version = parseImage(apiImage).Tag | ||
| } | ||
| if etcdImage != "" { |
There was a problem hiding this comment.
I think you still need to set the image when the etcd deployment is enabled.
There was a problem hiding this comment.
With these changes, the behaviour is now consistent with the latest vcluster (v0.22) when etcd.Deploy is enabled. But I understand the concern, I will check again to be sure and update with more details.
There was a problem hiding this comment.
@lizardruss I have checked and verified about the scenario that you mentioned- when etcd deployment is enabled - in that case it's going to take the default image value present in default values.yaml, as expected.
The reason being, we first get the default helm values (as mentioned above), then we read the values.yaml file provided by the user and merge override only those values which are supplied by the user to create the vcluster config. So, etcd.Deploy will be set to true and the image value will be used from default values.
Below are the test artifacts supporting the above-mentioned facts-
-
Here is the values.yaml file (vc20.yaml) which sets
etcd.Deploy.Enabled = trueand the etcd pod with the expected image version3.5.13:
-
Here is the result of
helm get valuescommand:
ApsTomar
force-pushed
the
issue-2398-fix-helm-values
branch
from
aadcf7c to
634d741
Compare
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-5526 (#2398)
Please provide a short message that should be published in the vcluster release notes
Fixed an issue in vcluster v0.20 where the controlPlane.backingStore.etcd's image is getting populated with default values even when it has been disabled.
What else do we need to know?
While reproducing the issue, I came to a conclusion that this issue happens in vcluster version 0.20 when k8s version < 1.30, a quick fix for the user would be to either upgrade vcluster to latest version OR upgrade k8s to a version >= 1.30
Now, for the users on vcluster 0.20 and having k8s version < 1.30, this PR would resolve the issue. Please refer to the artifact attached below. With this fix, controlPlane.backingStore.etcd's image will not get populated if disabled.
One thing to note here- similar to etcd image, there are distro images as well present in the output as mentioned in the issue. These can also be fixed in the similar fashion as this PR. Let me know if we want to resolve that along with this etcd image fix.