fix: remove kubernetes-version flag in vcluster create #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
kale-amruta
changed the title
|
@kale-amruta, I don't think it makes sense to deprecate something that doesn't even work anymore. So, I think you should drop all the logic behind this flag and even remove the flag itself. When using it, it should fail to indicate that it's not supported and avoid the confusion of #2294. |
FabianKramm
reviewed
Jan 14, 2025
|
@kale-amruta can you instead of deprecating this flag, remove it instead? |
kale-amruta
force-pushed
the
removeKuberneteVersion
branch
from
f459b87 to
af7604e
Compare
kale-amruta
changed the title
|
@FabianKramm Can you re-review this one? |
|
actually, @kale-amruta there are some failing errors from lint here, can you check them |
cbron
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #2294
resolves ENG-5242
Please provide a short message that should be published in the vcluster release notes
Remove the
kubernetes-versionflag invcluster createcommand, kubernetes version can now be configured from values.yaml.What else do we need to know?