Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added how to eneable-ssl-passthrough so users can avoid leaving the docs #1441

Merged

Conversation

mpetason
Copy link
Member

@mpetason mpetason commented Jan 4, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind documentation

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
keeps the user in our docs when configuring ingress so they won't have to leave and look at the nginx documentation. troubleshooting this took me longer than it should have and I had to end up referring to an old blog post that I wrote a year ago to remember how I got it to work.

Please provide a short message that should be published in the vcluster release notes
(docs) added the exact config change needed to enable-ssl-passthrough

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for vcluster-docs ready!

Name Link
🔨 Latest commit 0adb339
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6595fcea6f10490007a63d65
😎 Deploy Preview https://deploy-preview-1441--vcluster-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpetason thanks a lot for the PR! LGTM!

@FabianKramm FabianKramm merged commit 20fa039 into loft-sh:main Jan 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants