New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability of MasterRunner.client_listener #2422

Closed

lozovskaya wants to merge 1 commit into locustio:master from lozovskaya:improve_readability

lozovskaya commented Oct 14, 2023

improve readability of MasterRunner.client_listener and reduce the cyclomatic complexity from F to D


          improve readability of MasterRunner.client_listener and reduce the cy…

964a5a7

…clomatic complexity from F to D

Collaborator

cyberw commented Oct 16, 2023 •

edited

Loading

Some of these changes make a bit of sense, but others just make spaghetti code a completely unreadable spaghetti/function/OO hybrid monster.

A better improvement might be structured around putting the handling of each message type into its own function.

cyberw added the stale label

cyberw closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale