Skip to content

Commit

Permalink
Fix test coverage for Translator
Browse files Browse the repository at this point in the history
Fixed:
- Code coverage for "message_selector" option in Charcoal Translator
  • Loading branch information
mcaskill committed May 14, 2018
1 parent d0f46d2 commit 5c02c19
Showing 1 changed file with 27 additions and 7 deletions.
34 changes: 27 additions & 7 deletions tests/Charcoal/Translator/TranslatorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ public function setUp()
{
$this->obj = new Translator([
'locale' => 'en',
'message_selector' => new MessageSelector(),
'cache_dir' => null,
'debug' => false,
'manager' => $this->localesManager()
'manager' => $this->localesManager(),
'message_selector' => new MessageSelector(),
]);

$this->obj->addLoader('array', new ArrayLoader());
Expand Down Expand Up @@ -105,17 +105,37 @@ private function localesManager()
return $this->localesManager;
}

/**
* @return void
*/
public function testConstructorWithMessageSelector()
{
$selector = new MessageSelector();
$translator = new Translator([
'locale' => 'en',
'cache_dir' => null,
'debug' => false,
'manager' => $this->localesManager(),
'message_selector' => $selector,
]);

$this->assertSame($selector, $this->callMethod($translator, 'selector'));
}

/**
* @return void
*/
public function testConstructorWithoutMessageSelector()
{
$obj = new Translator([
'locale' => 'en',
'cache_dir' => null,
'debug' => false,
'manager' => $this->localesManager()
$translator = new Translator([
'locale' => 'en',
'cache_dir' => null,
'debug' => false,
'manager' => $this->localesManager(),
'message_selector' => null,
]);

$this->assertInstanceOf(MessageSelector::class, $this->callMethod($translator, 'selector'));
}

/**
Expand Down

0 comments on commit 5c02c19

Please sign in to comment.