Image Compression #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…saving them in ImageProperty.php
mcaskill
requested changes
Apr 8, 2022
Comment on lines
+612
to
+613
|
|
||
|
|
There was a problem hiding this comment.
Superfluous line breaks
Suggested change
Comment on lines
+349
to
+352
| if ($val) { | ||
| $this->imageCompression->compress($val); | ||
| } | ||
|
|
There was a problem hiding this comment.
If we using effects to create intermediate images (what we expect to show on the web site), why compress the the selected (original) image?
If we want to compress the original image, we should be attaching the image compression service to the ElfinderConnectorAction in charcoal-admin instead of charcoal-property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add image compression via the charcoal-image-compression package