Skip to content

Commit

Permalink
remove activejob configuration and base class
Browse files Browse the repository at this point in the history
Except for specific and relatively uncommon circumstances,
Sidekiq has a perfectly sufficient API and commonly used
conventions, and doesn't need an abstraction/wrapper around it.
  • Loading branch information
hiattp committed Jun 19, 2018
1 parent 22f37dd commit 59cf38d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
4 changes: 0 additions & 4 deletions app/jobs/application_job.rb

This file was deleted.

3 changes: 0 additions & 3 deletions config/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ class Application < Rails::Application
# -- all .rb files in that directory are automatically loaded after loading
# the framework and any gems in your application.

# Use Sidekiq as ActiveJob backend
config.active_job.queue_adapter = :sidekiq

# Configure generators, see: http://guides.rubyonrails.org/generators.html
config.generators do |g|
# Create appropriate tests in spec/ not test/
Expand Down
2 changes: 1 addition & 1 deletion config/initializers/sidekiq.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#
# Client Size = Puma Workers * (Puma Threads / 2) * Heroku Web Dynos
#
# Server Size = (Redis Connection Limit - Client Size - 2) / Heroku Job Dynos
# Server Size = (Redis Connection Limit - Client Size - 2) / Heroku Worker Dynos
# Server Size is set in sidekiq.yml in concurrency setting.
# Server size is concurrency + 2.

Expand Down

0 comments on commit 59cf38d

Please sign in to comment.