-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Joda DateTime library and update to java.time package #575
Conversation
Signed-off-by: Emily Gouge <[email protected]>
Signed-off-by: Emily Gouge <[email protected]>
Signed-off-by: Emily Gouge <[email protected]>
Signed-off-by: Emily Gouge <[email protected]>
Signed-off-by: Emily Gouge <[email protected]>
rather than org.joda.time.DataTime Signed-off-by: Frank Gasdorf <[email protected]>
Update EMF-Model to LocalDateTime
Signed-off-by: Emily Gouge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look and tried to remove DateTime elements completely. Independently from removing or keeping the elements, I cannot comile locally anymore. @egouge Hope you have more luck on this, however I'll try to setup a pairing session with @erdalkaraca who definitly has much more knowlege in the EMF field.
...ech.udig.omsbox/src/org/locationtech/udig/omsbox/view/actions/OmsScriptGenerationAction.java
Show resolved
Hide resolved
...it/src/org/locationtech/udig/project/element/provider/ElementItemProviderAdapterFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Emily Gouge <[email protected]>
Signed-off-by: Emily Gouge <[email protected]>
I was able to remove both timestep and elevation (and the date/time data type), regenerate the model and get it to compile. |
Awesome, this look promising. Could you please describe how you generated the code from the model? I assume you have Eclipse IDE with EMF Tooling installed (which version??)? I'll try too re-run code generation with the current state of your branch and check how far I can get Many thanks for your contribution! |
Hmm, just wondering why the sphinx-build fails in github action while it was fine on previous commits (python and sphinx version are still the same):
|
Signed-off-by: Emily Gouge <[email protected]>
Signed-off-by: Emily Gouge <[email protected]>
I tried to remove the old emf files and upgrade to new emf diagram files (replace .ecorediag with .aird files). In terms of how I re-generated the model:
|
@fgdrf Sorry if this is a silly question, I'm not sure with the process for merging pull request - Is merging this request something I am supposed to do? |
Was just testing to start/restart application with projects & maps. Looks good, but spotted some other problems I created issues for: |
Let me know if I need to do something more.