Synchronized Rendering (thread safety)

Synchronized Access on layers (and other places where getLayers is accessed). Signed-off-by: Michael Sementsov <[email protected]>
locationtech · Oct 17, 2018 · 64240f3 · fgdrf · Sep 18, 2019 · 64240f3
1 parent 48711db
commit 64240f3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/...org.locationtech.udig.project.ui/src/org/locationtech/udig/project/ui/ApplicationGIS.java b/...org.locationtech.udig.project.ui/src/org/locationtech/udig/project/ui/ApplicationGIS.java
@@ -802,7 +802,9 @@ public void run(IProgressMonitor monitor)
                 RendererCreator decisive = new RendererCreatorImpl();
                 decisive.setContext(tools);
 
-                decisive.getLayers().addAll(layersToRender);
+                synchronized (decisive.getLayers()) {
+                    decisive.getLayers().addAll(layersToRender);
+                }
 
                 SortedSet<RenderContext> sortedContexts = new TreeSet<RenderContext>(
                         decisive.getConfiguration());

diff --git a/...g.project/src/org/locationtech/udig/project/internal/render/impl/RendererCreatorImpl.java b/...g.project/src/org/locationtech/udig/project/internal/render/impl/RendererCreatorImpl.java
@@ -499,12 +499,14 @@ public SelectionLayer findSelectionLayer( ILayer targetLayer ) {
         } catch (IOException e) {
             return null;
         }
-        for( Layer layer : getLayers() )
-            if (layer instanceof SelectionLayer)
-                if (((SelectionLayer) layer).getWrappedLayer() == targetLayer)
-                    return (SelectionLayer) layer;
+        synchronized (getLayers()) {
+            for (Layer layer : getLayers())
+                if (layer instanceof SelectionLayer)
+                    if (((SelectionLayer) layer).getWrappedLayer() == targetLayer)
+                        return (SelectionLayer) layer;
 
-        return null;
+            return null;
+        }
     }
 
     /**