Conversation
Assisted-by: OpenAI Codex Signed-off-by: logprobz <321553542+logprobz@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lukealonso
pushed a commit
that referenced
this pull request
Sep 6, 2026
…points (#669) * Preserve aligned cache reuse alongside request boundary checkpoints Port the qualified hybrid retention, fine-hit, event, exact external-state, and aligned-budget changes onto dev/jovian-judgement. Keep endpoint bundles private and preserve their allocation, reader, and invalidation lifecycle. Retain the behavioral contributions from PRs #557, #643, #645, #646, #655, #656, #657, and #663. Resolve shared helpers once so fine and coarse replay boundaries are not expanded twice. Validation: 910 cache, scheduler, parser, event, connector, and endpoint regressions pass. The three literal LP26 cache regressions also pass. Co-authored-by: Jason Cook <jasonc@maxlyn.com> Co-authored-by: Martin Vit <martin@voipmonitor.org> Co-authored-by: Yifan Qiao <yifanqiao@inferact.ai> Co-authored-by: haic0 <149741444+haic0@users.noreply.github.com> Co-authored-by: tobymao <toby.mao@gmail.com> Signed-off-by: logprobz <321553542+logprobz@users.noreply.github.com> * Clean up cache regression fixtures for pre-commit checks Signed-off-by: logprobz <321553542+logprobz@users.noreply.github.com> --------- Signed-off-by: logprobz <321553542+logprobz@users.noreply.github.com> Co-authored-by: logprobz <321553542+logprobz@users.noreply.github.com> Co-authored-by: Jason Cook <jasonc@maxlyn.com> Co-authored-by: Martin Vit <martin@voipmonitor.org> Co-authored-by: Yifan Qiao <yifanqiao@inferact.ai> Co-authored-by: haic0 <149741444+haic0@users.noreply.github.com> Co-authored-by: tobymao <toby.mao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Micro-slicing can divide a usable prefill budget into slices that
_mamba_block_aligned_splitreduces to zero. With 2048-token scheduler/cache blocks, 256-token recurrent blocks, and three running prefills, a 4096-token budget is split into 1536/1280/1280-token slices. None can advance.This draft includes the chunk aligner's grid in the allocation quantum. The same budget then supplies two usable 2048-token slices. A mixed-prefill budget such as 2304 is rejected by the existing validation rather than accepted with an incompatible quantum.
Scope and relation to other PRs
This is a standalone 12-line runtime change against
integration/glm53-r26-lmcache-expandable-20260905. It does not depend on the cache-checkpoint follow-up and does not change cache retention or state alignment rules.#647 is closed. Current #648 replaces the micro-slicing path with automatic compute sharing and interleaved lanes. This draft fixes the path still present in the r26 base; it does not duplicate #648. If #648 lands first, maintainers should either retain this policy explicitly or port the allocation invariant to its replacement. The #648 branch has not been GPU-qualified with this patch.
The local LP26 screen found useful short-prompt convoy gains from interleaving, but the tested automatic profiles lost about 40% of median per-request decode compared with LP15. A micro-slicing profile passed the no-decode-loss gate, so preserving a working option is useful while the replacement is qualified. This is workload-specific evidence, not a claim that micro-slicing is universally better.
Behavior
The new tests construct real schedulers. They check actual split results for 2048/4096 budgets, reject the incompatible 2304 budget, and preserve both global-budget and long-prefill-cap sub-block exceptions. The three bug assertions fail on the unchanged r26 base.
Validation
CPU command in the LP26 runtime dependency environment, with this source checkout mounted and no GPU devices:
221 passed. No tests were skipped to accommodate this change.
Ruff check, Ruff format, and git diff whitespace checks pass for the changed files.
This automatic-quantum patch has not been installed into production or GPU-qualified. Production instead uses an explicitly compatible 4096 mixed-prefill budget. That complete LP26 profile, including other cache/runtime changes, passed a fresh comparison against LP15: +6.7% aggregate output at 16 clients, +7.8% at 32, +4.4% median request decode, and p95 TTFT within the unchanged 5% limit. It also passed long-context cached retrieval, tools/parser/vision checks, and 64 agent continuation turns. Those results motivate the invariant; they are not a performance claim for this code change.
Keep this draft pending maintainer agreement on #648 policy compatibility and a GPU replay of the final source.
AI assistance: OpenAI Codex prepared this change and ran the recorded checks at the submitter's request. Human line-by-line review is pending before marking the draft ready.
Superseded
Superseded by #669, now merged on dev/jovian-judgement. The coordinated port preserves endpoint checkpoint guards and includes the cache, scheduler, connector and event repairs from this earlier branch. The combined release passed full MTP3 and DFlash2 serving qualification and was promoted, with zero preemptions and all LP26 5% performance gates satisfied. Closing this older proposal to avoid duplicate integration.