r20: simplify prefill compute sharing and balance GLM cache groups - #635
Conversation
Replace the fairness-engine selector with one optional prefill-compute-share setting, retain fixed and automatic weighted-runtime scheduling, and remove the unsuccessful micro-slicing policy and its tuning surface. Auto starts conservatively at 0.4 while an omitted setting preserves stock scheduling. Signed-off-by: derek <derek.yates@live.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded. The weighted cache allocator is already present in the R26 source line, and the fairness portion has been replaced by the simpler combined scheduler implementation in #648. |
Summary
This is the clean follow-up for the exact
jovian-judgement-community-20260903-r20source branch.--prefill-compute-share {FLOAT|auto}control0.4, retaining bounded, pressure-aware adjustment and idle-only runtime switchingThe scheduler and allocator changes remain separate commits so they can be reviewed or integrated independently.
Scheduler contract
--prefill-compute-shareis the complete public control:auto: adaptive weighted compute share, initialized at0.4The development
GET/POST /prefill_fairnessAPI remains available for idle-only changes without a model reload. Removed selector and micro-slicing fields are rejected instead of silently ignored. Compute-share mode remains incompatible withprefill_schedule_interval > 1and unsynchronized data parallelism.This supersedes the r18-oriented composition in #627 for r20 integration while preserving its measured-runtime controller design. It also replaces the r20 copy of #625's selectable-engine surface with the simpler single-control contract.
Weighted GLM cache allocation
The #603 commits search a bounded set of compatible GLM-5.3 split-cache groupings and minimize maximum-request shared-pool memory cost, with fewer groups as the deterministic tie-breaker.
On the r20 DCP4 unit geometry:
fp8_ds_mlanvfp4_ds_mlaPhysical page formats, cache keys, and logical cache geometry are unchanged.
Validation
Exact base:
7015eb6949a93247df02fb6f9101d17c40bd83e8.CN4 Linux source/unit validation passed 65 focused tests:
Ruff and
git diff --checkpass on the touched source.Known qualification limits
Related work
OpenAI Codex assisted with the r20 replay, simplification, conflict resolution, source review, and focused validation. The submitted commits and test evidence were reviewed under maintainer direction.