perf(indexer): reuse immutable B12X C4 plans - #531
Conversation
Resolve each B12X C4 plan once per device, query geometry, page-table capacity, and serving mode. Reuse the immutable plan while materializing caller-owned workspace views and binding live metadata on every invocation. This preserves vLLM workspace ownership and live-tensor semantics. Two adapter tests verify plan reuse, per-call workspace rebinding, logical output indices, and profile workspace capacity. On TP4 GLM-5.3-Flash-NVFP4 with 4096-token chunked prefill, the idle 32k five-run median is 13,164 tok/s versus 13,141 tok/s for the DeepGEMM C4 control. Signed-off-by: Martin Vit <martin@voipmonitor.org>
|
Warning Review limit reachedNext included review available in 48 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
Result
Status: implemented and qualified for vLLM's B12X C4 indexer adapter.
The adapter resolves one immutable B12X plan for each device, query geometry,
page-table capacity, and serving mode. Every invocation reuses that plan while
binding live metadata and materializing views over caller-owned workspace.
Technical reason
Plan construction validates static geometry and resolves a kernel policy. None
of those properties changes between layer invocations for a loaded model.
Repeating plan construction in the prefill hot path adds Python and policy
resolution overhead without changing the selected operation.
Operation contract and compatibility
on every invocation; tensor addresses are not retained in the immutable
plan.
serving mode differs.
fallback selection are unchanged.
Validation
Source base:
dev/jovian-judgementat0b67266a0f37d6146a8403fb8482403c62f412d5./opt/venv/bin/python -B -m pytest -q \ tests/v1/attention/test_b12x_sparse_mla_api.py \ -k "dsa_indexer_reuses_plans_and_rebinds_shared_workspace"The parameterized adapter cases verify plan reuse, per-call workspace
rebinding, logical output indices, and profiling workspace capacity.
Result: 1 passed, 44 deselected.
The source-locked TP4/DCP4 integration at vLLM
3609a3db498698314bdc44920cad9f2d25796eb9and B12X composition6255090a03b12c3f7d552102a02fac0b542fb8c9completed model loading, memoryprofiling, target graph capture, DFlash2 graph capture, and 32k prefill on four
RTX PRO 6000 Blackwell GPUs. The B12X composition contains #259 and #260 over
master@fc1d4b68f7a5b0cfdb88bf06abccd869f5c589d5. This is an integrationqualification, not an end-to-end speed attribution to plan reuse alone.
AI assistance disclosure
AI assistance was used to implement and test the adapter, qualify the composed
runtime, and prepare this pull-request description.