perf(glm5next): use direct single-token KDA decode - #490
Closed
jackzampolin wants to merge 1 commit into
Closed
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
duplicates #504 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resulting behavior
Ordinary GLM-5.3 decode dispatches directly to the B12X single-token KDA specialization when the installed B12X exposes it. The direct path forwards caller-owned tensors and scheduler-owned state indices without copying through the generic packed-decode staging buffers.
Speculative, mixed, and variable-width decode remain on
run_kda(), including its device-side metadata and transaction validation. Older B12X installs keep the existing path through feature detection.Dependency
This is the vLLM integration counterpart to local-inference-lab/b12x#249. It is safe to merge before that PR because the dispatch is guarded by
hasattr(api, "run_kda_single_token").Validation
git diff --checkpasses.tests/models/test_glm5next_model.py -k b12x_kda: 3 passed, 28 deselected.The serving measurements are single-run canary evidence, not a general performance guarantee. The separate B12X sparse-MLA prefill regression remains outside this PR.
Duplicate check
Searched current open vLLM PRs for GLM, B12X, KDA, and decode work. No existing vLLM PR integrates the B12X #249 single-token API.
Assisted by OpenAI Codex. The operator reviewed the runtime scope; final human review remains required before merge.