[II] fix(ds4): use B12X DeepSeek attention namespaces - #485
Conversation
Bind DeepSeek V4 scratch planning and decode to the public compressed_sparse_mla namespace introduced by B12X commit 3ae0bf3a. The operation contract and workspace geometry remain unchanged. Assisted-by: OpenAI Codex <noreply@openai.com> Signed-off-by: Martin Vit <martin@voipmonitor.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughB12X runtime code now imports sparse indexer functionality from ChangesB12X module path updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR updates DeepSeek serving imports to the required public B12X namespaces while preserving tensor contracts and launch behavior; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
B12X exposes the DeepSeek sparse-attention indexer through attention.dsa_indexer and does not retain the former NSA namespace. Route runtime planning, decode, warmup, and their module fixture through the declared public API without changing indexer behavior. Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Festr <festr@users.noreply.github.com> Signed-off-by: Martin Vit <martin@voipmonitor.org>
Purpose
DeepSeek V4 serving must import the public attention namespaces declared by B12X
master.B12X commit
3ae0bf3a443047997d625d44ca24da8bd78904d5exposes compressed sparse MLA asb12x.attention.compressed_sparse_mla. B12X commit429a971340ed12e564e07e10ce1f2dbef65bcc7fexposes the DeepSeek Sparse Attention indexer asb12x.attention.dsa_indexer. Both commits intentionally remove the former namespaces without compatibility aliases.Infernal Invocation still imported the removed module paths during scratch planning, memory profiling, indexer warmup, and decode. A source-locked installation therefore failed before CUDA graph capture.
Resulting behavior
b12x.attention.compressed_sparse_mla.b12x.attention.dsa_indexer.Compatibility
The integration requires the public B12X API at or after commits
3ae0bf3aand429a9713. It does not restore removed aliases in B12X.Validation
tests/models/deepseek_v4/test_b12x_compressed_mla_workspace.py: 24 passed with B12Xmasterplus PR [GG] chore(b12x): port integration to renamed package #246; two pin-memory cases require an NVIDIA driver and were excluded from the CPU-only run.compressed_sparse_mla; the unpatched DSA import fails at memory profiling. Full TP2 runtime qualification will be attached after the release composition includes both commits.Duplicate check
No open pull request matching the B12X compressed sparse MLA or DSA indexer namespace migration exists in
vllm-project/vllmorlocal-inference-lab/vllmas of 2026-08-26.AI assistance was used to inspect the source-lock failures, update the namespace contract, and run the listed checks. Every changed line and the runtime evidence were reviewed by the submitter.
Summary by CodeRabbit