[II] fix(ds4): keep indexer scoring in breakable graphs - #429
Conversation
…#52492) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Co-authored-by: OpenAI Codex <codex@openai.com> Co-authored-by: Yongye Zhu <zyy1102000@gmail.com>
|
Warning Review limit reached
Next review available in: 15 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
65770a0
into
local-inference-lab:dev/infernal-invocation
Behavior
DeepSeek V4 breakable CUDA graph capture always records learned sparse-indexer scoring. The eager short-context optimization still selects every candidate without scoring when the compressed context fits within the top-k set.
Technical reason
Graph capture uses short dummy attention metadata, but the captured graph can replay with a longer cached prefix. Encoding the short-context branch into the graph makes long-prefix replay select the first candidate indices instead of ranking the learned indexer scores.
The shortcut is therefore gated by
torch.cuda.is_current_stream_capturing(). This is an exact backport of vLLM commit292187dd8ca1b1bfa195f25b2886262527269999from upstream PR vllm-project#52492.Compatibility
Validation
pytest -q --confcutdir=tests/models/deepseek_v4 tests/models/deepseek_v4/test_indexer_graph_capture.py: 2 passed.ruff checkandruff format --check: passed.References