Skip to content

[II] Replicate Kimi DSpark cache under target DCP - #364

Closed
voipmonitor wants to merge 1 commit into
agent/ii-external-draft-attention-configfrom
agent/ii-kimi-dspark-dcp-replication
Closed

voipmonitor wants to merge 1 commit into
agent/ii-external-draft-attention-configfrom
agent/ii-kimi-dspark-dcp-replication

Conversation

@voipmonitor

Copy link
Copy Markdown

Behavior

Kimi-K3 DSpark may run with a B12X MLA target that uses decode context parallelism. The external draft keeps a complete DCP1 KV cache on every target rank unless VLLM_DCP_SHARD_DRAFT=1 explicitly requests draft sharding.

The speculative configuration accepts target DCP only when the external Kimi draft selects B12X_MLA; other attention backends retain the DCP1 requirement.

Technical reason

Kimi-K3 target KV is partitioned by DCP, while an external DSpark model executes independently on every target rank. Marking the non-causal draft MLA cache as dcp_replicated gives each rank complete draft context without changing the target cache layout.

Compatibility

Validation

  • Ruff and Python compilation pass for all changed files.
  • Six Kimi DSpark configuration and cache-replication tests pass in the source-locked CUDA 13.3 / PyTorch 2.13 runtime image.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • dev/*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 06612d6c-f5be-410d-a652-fa938baed704

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@voipmonitor

Copy link
Copy Markdown
Author

The behavior implemented by this pull request is preserved in vLLM #389 as commit 770b244d7f1f. The stable patch ID differs because the DSpark DCP tests share imports and setup with the consolidated draft online-quantization coverage. The consolidated range-diff retains the pull request contract. Review and merge #389; this pull request is closed to avoid duplicate review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant