[II] Enable B12X DCP collectives at world size 16 - #338
Closed
voipmonitor wants to merge 1 commit into
Closed
voipmonitor wants to merge 1 commit into
voipmonitor wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 15, 2026
Use the B12X DCP runtime at world sizes 2, 4, 8, and 16 for query-head gather, LSE reduction, and graph warmup. Unsupported sizes retain the existing NCCL fallback. Validation: Ruff format/check and git diff --check pass. Thirty-seven relevant DCP tests pass in the CUDA 13.3/PyTorch 2.13 Kimi-K3 image, including explicit DCP16 gather, reduction, and warmup coverage.
voipmonitor
force-pushed
the
agent/ii-b12x-dcp16-world-size
branch
from
August 15, 2026 20:18
7ac5a6b to
db4765b
Compare
voipmonitor
changed the base branch from
dev/infernal-invocation
to
agent/ii-b12x-lazy-graph-pools
August 15, 2026 20:18
This was referenced Aug 15, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Qualified.
Behavior
B12X query-head gather, LSE reduction, and graph warmup accept DCP world sizes 2, 4, 8, and 16. Other world sizes continue to use the existing NCCL fallback.
Technical reason
B12X
DcpAllToAllPoolsupports world size 16, but the vLLM dispatch guards excluded it. The guard prevented TP16/DCP16 serving from selecting the B12X DCP transport even when its tensor geometry satisfied the runtime contract.Compatibility
No model-specific geometry, numerical operation, tensor format, channel ownership, or fallback behavior changes. TP2, TP4, and TP8 retain the same path.
Validation
git diff --checkpasses.tests/distributed/test_dcp_a2a.pypass in the CUDA 13.3/PyTorch 2.13 Kimi-K3 image.