[II] Own deferred accelerator weight tensors - #327
voipmonitor wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 40 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The behavior implemented by this pull request is preserved in vLLM #382 as commit |
Behavior
Layerwise online processing gives every deferred accelerator tensor independent
storage before queuing its normalized weight-loader arguments. The destination
parameter is never cloned, and CPU and meta tensors retain their existing
storage.
Technical reason
Streaming checkpoint loaders can expose accelerator views backed by a reusable
staging ring. Layerwise processing retains weight-loader arguments until all
checkpoint shards required by a layer arrive. Retaining a borrowed view across
another iterator step allows the staging ring to overwrite data that has not
yet reached the quantizer.
The ownership boundary is applied only where weight-loader execution is
deferred. Synchronous parameter loading remains zero-copy.
Compatibility
layerwise online processing; it is not model-specific.
Validation
source while tensor values remain exact.
InstantTensor ring, forcing multiple wraps; every retained deferred tensor
remains exact after iteration completes.
their original identities.
Test result: 3 passed on one NVIDIA GPU in the source-locked Kimi-K3 runtime
image; 5 unrelated tests were deselected.