[GG] fix(distributed): isolate semantic B12X PCIe graph channels - #247
Conversation
|
Warning Review limit reached
Next review available in: 13 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Assisted-by: OpenAI Codex Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
Address semantic-channel review feedback by closing custom all-reduce before its process groups, keeping finalizers non-collective, and hardening CUDA graph profiling cleanup. Assisted-by: OpenAI Codex Signed-off-by: Michel Belleau <michel.belleau@malaiwah.com>
f5662c0 to
42055eb
Compare
|
Superseded by #251. The DSpark context-KV FULL graph creates an additional distributed graph owner and therefore must land with this semantic channel lifecycle in one source state. #251 was rebuilt directly from the current dev/gilded-gnosis head, contains this PR plus the context graph feature, is non-draft and mergeable, and has no hidden stacked integration commit. Closing this duplicate avoids applying the same channel changes twice in release composition. |
Purpose
Port the reviewed semantic PCIe channel lifecycle from #216 to the current
b12xpackage contract. A process-local CUDA stream handle is not a stable identity for independently captured target, draft, encoder, profiling, production, and eager communication paths.What changes
channel_idvalues through V1/V2 CUDA graph capture, custom all-reduce, and DCP A2A.__del__non-collective.b12xpackage and updates the distributed regression tests.This preserves the behavior and review fixes from #216 without retaining the obsolete
sparkinferimport contract. It is intended to supersede #216.Validation
Paired with
b12xmaster plus PR local-inference-lab/b12x#125 on 2x RTX PRO 6000 Blackwell (remote GPUs 4-5):git diff --check: pass.No throughput or VRAM gain is claimed; this is a communication ownership and teardown correctness change.