Fix Kimi EAGLE3 draft config under DCP - #23
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesDraft-model KV cache dtype and attention backend overrides
Context parallelism seq-lens in draft attention metadata
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
draft_attention_backendanddraft_kv_cache_dtype).seq_lens=None.Root Cause
Kimi EAGLE3 launch configs used by earlier Kimi images include
draft_attention_backend=TRITON_MLAanddraft_kv_cache_dtype=fp8. Current chthonic rejected those fields as unexpected. Removing them got past validation but failed later when DCP was enabled because the draft speculator did not providedcp_local_seq_lensto the MLA metadata builder; the builder then replacedseq_lenswithNoneand crashed during warmup/generation.Validation
python3 -m py_compile vllm/config/speculative.py vllm/v1/spec_decode/llm_base_proposer.py vllm/v1/worker/gpu/spec_decode/speculator.pyvoipmonitor/vllm:chthonic-consecration-f1190eab-b12x0ff2847-pr20-cu132with Kimi K2.6 target,festr2/kimi-k2.6-eagle3-mla-fp8draft, TP8/DCP4,TRITON_MLA, fp8 KV, and the original speculative config./v1/chat/completionssmoke request without the previousNoneTypeDCP crash.Summary by CodeRabbit