Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion requirements/cuda.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ nvtx==0.2.15
fastsafetensors >= 0.3.2

# QuACK and Cutlass DSL for FA4 (cute-DSL implementation)
nvidia-cutlass-dsl[cu13]==4.6.0
# 4.6.0 spills the SM120 B12X W4A16 prefill kernel (255 registers and a
# 256-byte stack per thread); 4.5.3 restores spill-free code generation.
nvidia-cutlass-dsl[cu13]==4.5.3
Comment on lines +27 to +29

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Update the CUDA 12 CI selector rewrite for the exact pin.

This change from a >= requirement to ==4.5.3 means the rewrite in .github/workflows/scripts/build.sh:11-16, which only matches nvidia-cutlass-dsl[cu13]>=, no longer strips [cu13]. CUDA 12 CI therefore resolves this differently from docker/Dockerfile:245-267 and setup.py:1080-1103.

Make the CI rewrite match the package name independently of the version operator, or retain a requirement syntax compatible with that script.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@requirements/cuda.txt` around lines 27 - 29, Update the CUDA 12 dependency
rewrite in the build script around its nvidia-cutlass-dsl matching logic so it
recognizes the pinned ==4.5.3 requirement and removes the [cu13] extra
consistently with the Dockerfile and setup.py paths. Match the package
independently of the version operator rather than reverting the exact pin.

quack-kernels>=0.4.0 # Required for tml-fa4

# Tokenspeed_MLA for faster mla with spec decode
Expand Down
Loading