Skip to content

[gg-rebased] perf(nf3): integrate Grid188 hybrid decode - #121

Merged
lukealonso merged 2 commits into
local-inference-lab:dev/gilded-gnosis-rebasefrom
voipmonitor:codex/gg-rebased-nf3-grid188-20260718
Jul 18, 2026
Merged

[gg-rebased] perf(nf3): integrate Grid188 hybrid decode#121
lukealonso merged 2 commits into
local-inference-lab:dev/gilded-gnosis-rebasefrom
voipmonitor:codex/gg-rebased-nf3-grid188-20260718

Conversation

@voipmonitor

Copy link
Copy Markdown

Summary

Forward-port the vLLM side of the mapped Grid188 NF3 hybrid decode path from #113 onto dev/gilded-gnosis-rebase at 533b037f35.

The two commits retain:

  • exact-geometry fail-closed admission for the TP4 64-NVFP4 + 192-NF3 hybrid;
  • the nvfp4_nf3_hybrid online quantization integration;
  • VLLM_NF3_GRID188_DECODE as the explicit runtime gate;
  • the per-step host-synchronization removal.

Requires local-inference-lab/b12x#36 (bc85ef3619) until that PR is merged.

Measured contribution

Matched TP4/DCP4/MTP3 C1 decode on the same GPUs and current v18 runtime:

Path Median server decode
Grid188 disabled 95.34 tok/s
Grid188 enabled 106.28 tok/s
Incremental gain +11.47%

Port validation

  • ruff check: pass
  • ruff format --check: pass
  • git diff --check: pass
  • Integrated CUDA/E2E validation is tracked with the v19 image.

Supersedes #113 for the upstream-rebased GG line.

voipmonitor and others added 2 commits July 18, 2026 10:56
Co-authored-by: David Young <david@davidsyoung.com>
Co-authored-by: David Young <david@davidsyoung.com>
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@voipmonitor, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cf119554-e34d-4404-ac6e-88ce79a8321b

📥 Commits

Reviewing files that changed from the base of the PR and between 533b037 and dafc07c.

📒 Files selected for processing (7)
  • tests/quantization/test_nvfp4_nf3_hybrid.py
  • tests/v1/attention/test_indexer_dcp_localize.py
  • vllm/config/quantization.py
  • vllm/envs.py
  • vllm/model_executor/layers/quantization/nvfp4_nf3_hybrid.py
  • vllm/v1/attention/backends/utils.py
  • vllm/v1/worker/gpu/spec_decode/autoregressive/speculator.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lukealonso
lukealonso merged commit 6ce1180 into local-inference-lab:dev/gilded-gnosis-rebase Jul 18, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants