fix(indexer): remove duplicate RoPE quant helper - #108
Conversation
📝 WalkthroughWalkthroughThe PR centralizes fake B12X DCP merge setup across tests, updates the merge argument and schedule metadata configuration, and removes module-level sparse indexer imports while relocating a fused quantization definition. ChangesB12X sparse indexer maintenance
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Follow-up validation: the three stale B12X fixtures were aligned with the current FF contracts without changing runtime behavior. The complete |
Summary
_fused_indexer_q_rope_quant_kernel/fused_indexer_q_rope_quantdefinitionsWhy
The duplicate entered the FF branch when the B12X sparse-indexer integration and upstream sparse-indexer work converged. Python silently replaced the first wrapper with the second, so runtime behavior was unaffected, but Ruff reports
F811plus the two staleF401imports. This can fail pre-commit for later PRs that touch the file.Validation
ruff check vllm/model_executor/layers/sparse_attn_indexer.pyruff format --check vllm/model_executor/layers/sparse_attn_indexer.pygit diff --check15 passedintests/model_executor/layers/test_sparse_attn_indexer_b12x.pySummary by CodeRabbit
Refactor
Tests