fix(ds4): isolate auxiliary-stream events across CUDA graphs - #102
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
DS4 sparse attention reuses auxiliary streams for indexer and post-GEMM work. CUDA events from one graph capture could be recycled or overwritten while another captured graph still referenced them. The resulting cross-graph aliasing produced races/corruption; globally disabling overlap avoided the race but regressed MTP and DSpark performance.
Fix
This is a clean current-FF extraction from the experimental #88 history. It intentionally excludes unrelated helper-script, custom-allreduce, and DSpark capacity-controller changes.
Validation
python -m pytest -q tests/models/deepseek_v4/test_attention_stream_events.py tests/test_multi_stream_utils.pyruff check,ruff format --check, andgit diff --check