fix(kv cache): preserve MLA quantization metadata when unifying page sizes - #100
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
unify_kv_cache_spec_page_size()reconstructedMLAAttentionSpecobjects without carryingkv_quant_mode. A quantized MLA cache could silently lose its quantization metadata while page sizes were normalized, causing downstream allocation or backend selection to treat it as the default mode.Fix
Propagate
kv_quant_modeinto the reconstructed spec and add coverage for heterogeneous MLA/SWA/indexer cache groups.This is the current-FF replacement for the metadata fix previously embedded in #88.
Validation
ruff checkandruff format --checkon changed filesgit diff --check