Conversation
Signed-off-by: logprobz <321553542+logprobz@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permit recurrent blocks to divide target blocks, matching the fine-grained prefix-hit geometry supported by vLLM PR #646. The current launcher rejects target2048 / recurrent256 before the engine can start, although that combination is used by the qualified LP27 cache integration.
This changes only the divisibility check and its error message. Positive-integer and multiple-of-64 validation remain active, and the independent LMCache chunk check is unchanged.
Validation: the original launcher rejects 2048/256. With this change, dry runs accept recurrent256, 2048, and 4096 with target2048, and reject recurrent384, 0, -64, and 65. Bash syntax and whitespace checks pass. The same launcher change is in the four-GPU LP27 image tested with DFlash2 K3, Marlin, TP4/DCP1, and 524288 context.
Related library changes: local-inference-lab/vllm#646, local-inference-lab/vllm#655, local-inference-lab/vllm#663. This launcher update requires an engine that supports the selected geometry.
Prepared with AI assistance and independent source review.