Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Independent validation of the filesystem eviction-ledger fix on the shared GLM/Qwen/DS4 serving image:
The integration preserves R32's bounded long-key paths and legacy-path cleanup: every representable path is processed, missing files count as successful deletion, and genuine I/O errors propagate. The CPU filesystem extension is rebuilt; all audited CUDA/vLLM/FlashKDA binaries remain byte-identical. The sidecar remains CPU-only and GPU copies stay worker-owned. Complete attributed integration preserves Derek Yates's two commits with source-commit references. This PR remains the canonical review unit; no duplicate PR was created. Scope is filesystem-ledger correctness and a bounded GLM transport regression check, not fresh TP8, NVFP4-KV or Qwen/DS4 external-cache qualification. |
|
Superseded by #49, which now preserves Derek Yates’s filesystem eviction-ledger commits together with bounded cache-key paths. The audited #67 head ec09897 is an ancestor of #49 head b4b79a0. Canonical and legacy files must both be absent before retiring ledger accounting; missing files are idempotent and actual deletion errors retain the ledger. The affected native implementation matches the published R34 source, and 116 filesystem/native-adapter tests pass. Closing this separate review unit avoids stacking two overlapping filesystem lifecycle patches; contribution credit and Git history remain intact. |
What this PR does / why we need it:
fs_nativereturned a false per-key delete result when an object was alreadyabsent.
NativeConnectorL2Adapterconsequently retained that key's byteaccounting and LRU entry forever, causing repeated no-op eviction and eventual
store admission failures. A concurrent re-store could create this state because
L2 eviction did not protect keys with pending native store completions.
This change makes native filesystem deletion idempotent for an already-absent
object while preserving filesystem errors, and excludes pending-store keys from
adapter deletion. Regression tests cover both ledger reconciliation and the
store/delete completion race.
Special notes for your reviewers:
Reproduced on cn4 with qualified image
localinferencelab/vllm@sha256:c9ad4a6ef4aa55232df9ed1a37e85d94eb8c7d5349561a6cbe828e72b61de83c(LMCache
35ad809f): after removing a tracked payload, two deletes left the20-byte ledger entry and key tracking unchanged.
Validation:
NO_GPU_EXT=1in the qualified r32 environment.test_native_connector_l2_adapter.pyandtest_fs_native_connector.py.Current unrelated
devCI failures:multiprocess test because its
_FakeStorageManagerlacks the existingabort_writemethod; the remaining Python matrix jobs are then cancelled.unchanged vLLM integration path because
KVConnectorBlockState.block_idshas been replaced by
get_block_ids.CodeRabbit reports success but skips automatic review because this OSS
repository has fewer than ten stars and therefore requires a manual review
trigger.
If applicable: