Skip to content

Report engine-driven shared-memory transport identity - #56

Closed
voipmonitor wants to merge 1 commit into
devfrom
feat/engine-driven-shm-status-20260905
Closed

voipmonitor wants to merge 1 commit into
devfrom
feat/engine-driven-shm-status-20260905

Conversation

@voipmonitor

Copy link
Copy Markdown

Status

Implemented and qualified.

Resulting behavior

The engine-driven transfer module reports its shared-memory pool through the existing status endpoint:

{
  "engine_driven_shm_pool": {
    "shm_name": "lmcache_l1_pool_<instance>",
    "pool_size": 25769803776
  }
}

Operators can distinguish shared-memory transport from pickle fallback and verify the exact pool name and capacity without inspecting process memory maps.

Compatibility

The change is observability-only. It does not alter cache storage, transfer ordering, allocator ownership, fallback policy, or wire protocol.

Validation

  • Focused status test: 1 passed.
  • Ruff check and format: passed.
  • A live 24 GiB engine-driven pool reported the expected POSIX shared-memory object and exact byte capacity through /status.
  • The standalone cache process remained CPU-only while vLLM workers performed gather and scatter.

Development disclosure

The implementation and validation were completed with OpenAI Codex assistance under human direction.

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 6b5ffd5b-7a9f-434b-82a8-0e7956f5a08d

📥 Commits

Reviewing files that changed from the base of the PR and between 7ed4675 and a726d46.

📒 Files selected for processing (2)
  • lmcache/v1/multiprocess/modules/engine_driven_transfer.py
  • tests/v1/multiprocess/test_engine_driven_transfer.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@voipmonitor

Copy link
Copy Markdown
Author

Community integration receipt for #56: this exact PR head is already merged into integration/local-inference-lab through 0fae2935.

The original contributor commits are preserved. Exact head ancestry was verified, not inferred from equivalent file contents. Closing this dev-targeted review because its community integration is complete; this is not a claim that it merged into dev. Further community changes must target integration/local-inference-lab. GitHub cannot retarget an already-contained head because there are no new commits to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant