Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update checker functionality #538

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Add update checker functionality #538

merged 3 commits into from
Jan 25, 2024

Conversation

royshil
Copy link
Collaborator

@royshil royshil commented Jan 23, 2024 •
edited
Loading

@royshil royshil requested a review from umireon January 23, 2024 18:25
@royshil royshil self-assigned this Jan 23, 2024
@royshil royshil mentioned this pull request Jan 23, 2024
Closed
@umireon
Copy link
Member

umireon commented Jan 23, 2024

Can we remove Qt dependency?

@royshil royshil mentioned this pull request Jan 23, 2024
Closed
@royshil
Copy link
Collaborator Author

royshil commented Jan 23, 2024

Can we remove Qt dependency?

we still use it for a few things. i can work on removing everything and check back in here

@umireon
Copy link
Member

umireon commented Jan 23, 2024

I'm OK with not removing Qt dependency now. It can be removed later.

umireon
umireon approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royshil royshil mentioned this pull request Jan 23, 2024
Closed
@royshil
Update CMakeLists.txt and CMakePresets.json to disable Qt and add Fou…
6514037 
…ndation framework

Remove UpdateDialog.cpp and UpdateDialog.hpp
Refactor code in background-filter.cpp and enhance-filter.cpp
@royshil
Refactor code to use std::regex_replace for plugin info replacement
cfec7b2
@royshil
Copy link
Collaborator Author

royshil commented Jan 25, 2024

@umireon i've removed Qt dep
please check it out

umireon
umireon approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@umireon umireon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royshil royshil merged commit ab3e956 into main Jan 25, 2024
6 checks passed
@royshil royshil deleted the roy.remove_update_dialog_for_message_prop branch January 25, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umireon umireon umireon approved these changes

Assignees

@royshil royshil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royshil @umireon