-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libcurl from Mac and Windows #420
Conversation
I confirmed this works on Windows and Mac |
I confirmed it works on Linux too. |
i actually think this is not necessary let me know what you think.. |
I agree with your thought. |
@royshil This change saves 6 minutes on Mac and this saves time more than pre-built OpenCV. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK we can roll with this
We don't need to bundle libcurl on Mac and Windows because these OSes have their native HTTP clients.
The signature must include a callback because QTimer must be executed on the main thread.