Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libcurl from Mac and Windows #420

Merged
merged 13 commits into from
Aug 14, 2023
Merged

Conversation

umireon
Copy link
Member

@umireon umireon commented Aug 11, 2023

We don't need to bundle libcurl on Mac and Windows because these OSes have their native HTTP clients.

The signature must include a callback because QTimer must be executed on the main thread.

@umireon
Copy link
Member Author

umireon commented Aug 11, 2023

I confirmed this works on Windows and Mac

@umireon
Copy link
Member Author

umireon commented Aug 11, 2023

I confirmed it works on Linux too.

@umireon umireon requested a review from royshil August 11, 2023 13:19
@royshil
Copy link
Collaborator

royshil commented Aug 11, 2023

i actually think this is not necessary
first - libcurl seems to work perfectly fine, and it's well supported cross-platform
second - the savings in build time are not that great, about 2 minutes. a much bigger savings is from the prebuilt static OpenCV libs
and also - using libcurl made us have a unified simple API for fetching data which is easier to maintain than platform-specific code.

let me know what you think..

@umireon
Copy link
Member Author

umireon commented Aug 12, 2023

I agree with your thought.

@umireon umireon closed this Aug 12, 2023
@umireon umireon deleted the umireon.remove-curl-from-mac-win branch August 12, 2023 01:52
@umireon umireon restored the umireon.remove-curl-from-mac-win branch August 12, 2023 01:56
@umireon umireon reopened this Aug 12, 2023
@umireon
Copy link
Member Author

umireon commented Aug 12, 2023

@royshil This change saves 6 minutes on Mac and this saves time more than pre-built OpenCV.
https://github.com/royshil/obs-backgroundremoval/actions/runs/5838854087
https://github.com/royshil/obs-backgroundremoval/actions/runs/5838815434

Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK we can roll with this

@umireon umireon merged commit e48b83c into main Aug 14, 2023
@umireon umireon deleted the umireon.remove-curl-from-mac-win branch September 29, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants