Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to include libonnxruntime.1.15.1 #348

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Fix to include libonnxruntime.1.15.1 #348

merged 1 commit into from
Jun 24, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Jun 24, 2023

Closes #347

@umireon umireon mentioned this pull request Jun 24, 2023
Closed
@umireon umireon requested a review from royshil June 24, 2023 00:32
@umireon umireon added this to the v1.0.3 milestone Jun 24, 2023
royshil
royshil reviewed Jun 24, 2023
View reviewed changes
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this is needed?
The two lines you add are exactly the same as the line youve removed below...

@umireon
Copy link
Member Author

umireon commented Jun 24, 2023

Onnxruntime_LINK_LIBS must be present before Onnxruntime_INSTALL_LIBS because INSTALL one depends on LINK one.
And it must be present after FetchContent_MakeAvailable because it depends on onnxruntime_SOURCE_DIR and SOURCE one is defined after FetchContent_MakeAvailable.

Is this reasonable?

@umireon umireon mentioned this pull request Jun 24, 2023
Closed
@umireon umireon requested a review from royshil June 24, 2023 03:33
@royshil
Copy link
Collaborator

royshil commented Jun 24, 2023

Ok this makes sense

royshil
royshil approved these changes Jun 24, 2023
View reviewed changes
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umireon umireon merged commit f1db090 into main Jun 24, 2023
@umireon umireon deleted the umireon.fix-libonnxruntime branch June 24, 2023 08:44
@umireon umireon mentioned this pull request Jun 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royshil royshil royshil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.

1.0.2: Complains about missing libonnxruntime.so.1.15.1 (1.0.1 works fine) - Xubuntu 22.04 LTS
2 participants
@umireon @royshil