Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use patched onnxruntime for Arch and Fedora build #235

Merged
merged 7 commits into from
Apr 2, 2023
Merged

Use patched onnxruntime for Arch and Fedora build #235

merged 7 commits into from
Apr 2, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Mar 31, 2023 •
edited
Loading

@umireon umireon closed this Mar 31, 2023
@umireon umireon reopened this Apr 1, 2023
@royshil
Copy link
Collaborator

royshil commented Apr 1, 2023

@umireon I would very very much prefer if we didn't do it this way with an external dependent repo

If we need to patch onnxruntime we can bring the .patch diff file to this repo
Download the original source tar.gz and apply the patch file before building it.

@umireon
Copy link
Member Author

umireon commented Apr 2, 2023

Upstream doesn't seem to fix the problem very soon so we need a patch for now, I suppose.

royshil
royshil approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good
Ship it!

@umireon umireon merged commit 4c2e152 into main Apr 2, 2023
@umireon umireon deleted the umireon.use-patched-onnxruntime branch April 2, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royshil royshil royshil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umireon @royshil