Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gs_effect_set_texture #228

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Use gs_effect_set_texture #228

merged 1 commit into from
Mar 30, 2023

Conversation

umireon
Copy link
Member

@umireon umireon commented Mar 29, 2023

This filter changed the color of the image. This change fixes the filter to keep the color of the image.

Fixes #218

スクリーンショット 2023-03-30 1 49 36

スクリーンショット 2023-03-30 1 49 38

@umireon umireon requested a review from royshil March 29, 2023 17:03
royshil
royshil approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! thanks very much for this

@Sparronator9999 Sparronator9999 mentioned this pull request Mar 29, 2023
Closed
@umireon umireon merged commit 1f3113b into main Mar 30, 2023
@umireon umireon deleted the umireon.fix-color-space branch March 30, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royshil royshil royshil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Background Removal effect only works with Limited colour space
2 participants
@umireon @royshil