-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpak #198
Flatpak #198
Conversation
I confirmed that these files can generate the right flatpak distribution. |
Only problem I faced when I wanted to build this locally is that the archive downloaded is pointing to HEAD and the SHA256 commit was incorrect - changing the block to the following makes it work for me: - type: archive
url: https://github.com/royshil/obs-backgroundremoval/archive/refs/heads/umireon.flatpak-build.tar.gz
sha256: b8be520c9f12afb4689b04b237c3f3d17c4c9b1dcac61bbb89533b3ede35b8c4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license is an issue for me.
<project_license>GPL-2.0</project_license> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel very uncomfortable changing the license to GPL 2.
MIT is a far more permissive license.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that but we are forced to use GPL-2.0. Of course, I'm against GPL.
I revert this change when #199 is rejected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can go to GPLv2
it's unfortunate. very restrictive...
but all of OBS is GPLv2 and even the obs-plugintemplate which this plugin came from! 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that true
i will submit naturally as soon as we land this and release 0.5.15 |
I'm not going to merge this PR into this repo. |
let me know when to submit the package to flathub |
It would be great to submit it right after v0.5.15 is out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets land this
theres a PR to bring it up in flathub flathub/flathub#4016 |
Thank you! It seemed to work on FlatHub! |
@royshil Can you update the PR for FlatHub? |
This plugin on the FlatHub have been released 🎉 |
You can install this plugin via this command:
|
I want to submit this plugin to FlatHub.