Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak #198

Closed
wants to merge 19 commits into from
Closed

Flatpak #198

wants to merge 19 commits into from

Conversation

umireon
Copy link
Member

@umireon umireon commented Mar 21, 2023

I want to submit this plugin to FlatHub.

@umireon umireon added this to the v0.5.15 milestone Mar 21, 2023
@umireon
Copy link
Member Author

umireon commented Mar 21, 2023

I confirmed that these files can generate the right flatpak distribution.
@royshil Can you submit these files to FlatHub and make them available on FlatHub?
https://github.com/flathub/flathub/wiki/App-Submission#how-to-submit-an-app

@umireon umireon requested a review from royshil March 21, 2023 13:30
@umireon umireon mentioned this pull request Mar 21, 2023
@bergmannf
Copy link
Contributor

bergmannf commented Mar 21, 2023

Only problem I faced when I wanted to build this locally is that the archive downloaded is pointing to HEAD and the SHA256 commit was incorrect - changing the block to the following makes it work for me:

      - type: archive
        url: https://github.com/royshil/obs-backgroundremoval/archive/refs/heads/umireon.flatpak-build.tar.gz
        sha256: b8be520c9f12afb4689b04b237c3f3d17c4c9b1dcac61bbb89533b3ede35b8c4

Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license is an issue for me.

<project_license>GPL-2.0</project_license>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel very uncomfortable changing the license to GPL 2.
MIT is a far more permissive license.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that but we are forced to use GPL-2.0. Of course, I'm against GPL.
I revert this change when #199 is rejected.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can go to GPLv2
it's unfortunate. very restrictive...
but all of OBS is GPLv2 and even the obs-plugintemplate which this plugin came from! 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that true

@royshil
Copy link
Collaborator

royshil commented Mar 21, 2023

I confirmed that these files can generate the right flatpak distribution. @royshil Can you submit these files to FlatHub and make them available on FlatHub? https://github.com/flathub/flathub/wiki/App-Submission#how-to-submit-an-app

i will submit naturally as soon as we land this and release 0.5.15
and fix the SHA

@umireon
Copy link
Member Author

umireon commented Mar 21, 2023

I'm not going to merge this PR into this repo.
It would rather be good to send the content of this PR with v0.5.15 SHAs to FlatHub.

@royshil
Copy link
Collaborator

royshil commented Mar 21, 2023

I'm not going to merge this PR into this repo. It would rather be good to send the content of this PR with v0.5.15 SHAs to FlatHub.

let me know when to submit the package to flathub

@umireon
Copy link
Member Author

umireon commented Mar 21, 2023

@royshil

let me know when to submit the package to flathub

It would be great to submit it right after v0.5.15 is out.
V0.5.15 must include #203 for a successful Flatpak build.
I will change the contents of Flatpak metadata on this PR for v0.5.15 so that you can use the files on this PR for submitting to FlatHub.

Copy link
Collaborator

@royshil royshil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets land this

@royshil
Copy link
Collaborator

royshil commented Mar 26, 2023

theres a PR to bring it up in flathub flathub/flathub#4016

@umireon
Copy link
Member Author

umireon commented Mar 27, 2023

Thank you! It seemed to work on FlatHub!

@umireon
Copy link
Member Author

umireon commented Apr 20, 2023

@royshil Can you update the PR for FlatHub?

@umireon
Copy link
Member Author

umireon commented May 9, 2023

This plugin on the FlatHub have been released 🎉

@umireon umireon closed this May 9, 2023
@umireon
Copy link
Member Author

umireon commented May 9, 2023

You can install this plugin via this command:

flatpak install com.obsproject.Studio.Plugin.BackgroundRemoval

@umireon umireon deleted the umireon.flatpak-build branch July 21, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants