Skip to content

refactor(pgvector-embedded): vendor shared control/SQL once, not per-platform (−2.7k lines) #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buremba merged 2 commits into from
May 20, 2026
Merged

refactor(pgvector-embedded): vendor shared control/SQL once, not per-platform (−2.7k lines) #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aea9ea
refactor(pgvector-embedded): vendor shared control/SQL once, not per-…
buremba May 20, 2026
36a62c4
style: apply biome formatting to pgvector-embedded injector
buremba May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/workflows/build-pgvector-embedded.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,14 @@ jobs:
- uses: actions/upload-artifact@v4
with:
name: pgvector-${{ matrix.platform }}
path: packages/pgvector-embedded/prebuilt/${{ matrix.platform }}
# The platform-specific library plus the shared control/SQL (vendored
# once at the prebuilt root). The least-common-ancestor is `prebuilt/`,
# so the artifact lays out as `<platform>/vector.*`, `vector.control`,
# `vector--*.sql`.
path: |
packages/pgvector-embedded/prebuilt/${{ matrix.platform }}
packages/pgvector-embedded/prebuilt/vector.control
packages/pgvector-embedded/prebuilt/vector--*.sql
if-no-files-found: error

open-pr:
Expand All @@ -91,12 +98,17 @@ jobs:

- name: Stage regenerated artifacts
run: |
PREBUILT=packages/pgvector-embedded/prebuilt
for dir in /tmp/pgvector-artifacts/pgvector-*; do
platform="$(basename "$dir" | sed 's/^pgvector-//')"
dest="packages/pgvector-embedded/prebuilt/${platform}"
dest="$PREBUILT/${platform}"
rm -rf "$dest"
mkdir -p "$dest"
cp -R "$dir/." "$dest/"
# Platform-specific library lives under <platform>/ in the artifact.
cp "$dir/$platform/"* "$dest/"
# Control + SQL are byte-identical across platforms — refresh the
# single shared copy at the prebuilt root (last writer wins).
cp "$dir"/vector.control "$dir"/vector--*.sql "$PREBUILT/"
done

- name: Open PR
Expand Down
Loading
Loading