docs(agents): require multi-replica k8s correctness on every change#962
Conversation
Per-pod in-memory state (SseManager connections + backlog, the workers map, the deployment lock cache) means a change correct single-process can be broken under N>1 app replicas behind ClientIP affinity. Make multi-replica correctness an explicit gate, clarify that 'No Docker/Kubernetes' applies to worker orchestration only (the app itself is a multi-replica Deployment), and note the API/SSE cross-pod delivery gap.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the Orchestration section of ChangesArchitecture Documentation Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Standing rule: every change must be correct under N>1 app replicas (ClientIP affinity, per-pod in-memory
SseManager/workersmap). Clarifies that "No Docker/Kubernetes" applies to worker orchestration only — the app is a multi-replica k8s Deployment — and flags the API/SSE cross-pod delivery gap. Docs-only.Extracted from the (closed) #958 worker-failure work, where an in-memory fix was caught being single-process-only.
Summary by CodeRabbit