feat(core)!: drop unused module-lifecycle public types; consolidate wire + session-file utilities

[buremba]

Summary

Multi-round simplification on packages/core + packages/server + packages/agent-worker. Cumulative ~385 LOC net deletion across 34 files. Includes a breaking change for @lobu/core: removes public types that were a speculative future-extensibility seam with zero internal consumers.

Breaking change

Drops the following types from @lobu/core's public index.ts:

• ActionButton (was previously exported)
• ModuleSessionContext (was previously exported)
• Plus the internal interfaces they were part of: WorkerModule, WorkerContext, DispatcherModule, DispatcherContext, the no-op BaseModule lifecycle methods (initWorkspace/onSessionStart/onSessionEnd/onBeforeResponse), generateActionButtons + handleAction dispatcher surface, getContainerAddress, ModuleRegistry.getWorkerModules.

Internal consumers: zero. Agent verified across all monorepo packages including @lobu/openclaw-plugin. The dispatcher had no real handlers wired up; the lifecycle hooks had no real subclasses overriding them (only no-op BaseModule defaults).

External consumers (npm): speculative. Last touched only by prior cleanup PR #820. Worth flagging in release notes; release-please should bump @lobu/core major (v7.x → v8.0).

Other simplifications

• Hoist MessagePayload + JobType + QueuedMessage into @lobu/core/worker/wire; delete 3 re-export shim files; migrate 10 importers to pull from @lobu/core directly.
• Hoist session.jsonl parser into @lobu/core/utils/session-file; collapse worker + gateway parsers into one canonical impl (debug-log on malformed JSONL on gateway side — flagged in commit body). findSessionFile deliberately kept split — different path policies (1-level vs 3-level depth + traversal guard).
• Delete unused dynamic-import plugin path in registerAvailableModules() (both call sites passed no args).
• Dedupe ModelOption + PrefillSkill/PrefillMcpServer to @lobu/core; update 9 importers.
• Delete dead moduleData / setModuleData wire plumbing (5 write-only sites, zero readers after the lifecycle deletion).
• Drop the dead TModuleData generic from ModuleInterface / OrchestratorModule / BaseModule.

Process

Built across 5 rounds of spike commits driven by codex exec --config model_reasoning_effort=high review at each round. Codex initial verdicts: NOT ENOUGH (4 rounds). Final verdict: ENOUGH, ship as breaking PR. All wip(spike): commit history preserved on branch — squash on merge.

Test plan

• make typecheck clean
• make build-packages clean
• Worker boots, gateway boots, message round-trip works
• release-please picks up the feat!: title and proposes @lobu/core v8.0.0 in the next release PR

Summary by CodeRabbit

• Refactor

  • Consolidated internal type definitions and utilities into a shared core package for improved code organization and consistency across services.
  • Simplified the module system architecture by removing unused worker-specific features and lifecycle management.
  • Streamlined session file parsing with shared utilities for handling message history and statistics.

• Chores

  • Removed unused moduleData functionality from worker transport layer.
  • Cleaned up unused module lifecycle and registration patterns.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 5.00000% with 57 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
packages/core/src/utils/session-file.ts	3.38%	57 Missing ⚠️

📢 Thoughts on this report? Let us know!

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR refactors the module system architecture by centralizing worker↔gateway wire contract types into @lobu/core, removing per-instance module data tracking, simplifying module registry APIs, and extracting shared session parsing utilities. The changes span agent-worker, server, and core packages with coordinated import and type definition updates.

Changes

Module System and Wire Contract Refactoring

Layer / File(s)	Summary
Wire contract centralization packages/core/src/worker/wire.ts, packages/agent-worker/src/gateway/types.ts, packages/server/src/gateway/infrastructure/queue/queue-producer.ts, packages/core/src/index.ts, test files and auth modules	Create new packages/core/src/worker/wire.ts containing centralized JobType, MessagePayload, and QueuedMessage type definitions; remove local exports from agent-worker and server; update ~30 import statements across both packages to source these types from @lobu/core instead.
Module data removal packages/core/src/worker/transport.ts, packages/core/src/types.ts, packages/agent-worker/src/gateway/gateway-integration.ts, packages/agent-worker/src/modules/lifecycle.ts, packages/agent-worker/src/openclaw/worker.ts	Remove setModuleData() method from WorkerTransport interface; remove moduleData optional field from ThreadResponsePayload; delete HttpWorkerTransport.moduleData field and its injection into response payloads; delete initModuleWorkspace(), onSessionStart(), and collectModuleData() lifecycle functions; remove module data collection/wiring from worker execution flow.
Module system simplification packages/core/src/modules.ts, packages/server/src/gateway/modules/module-system.ts, packages/agent-worker/src/index.ts, packages/server/src/gateway/services/core-services.ts	Change ModuleInterface from generic to non-generic; narrow IModuleRegistry to remove getWorkerModules() and registerAvailableModules() methods; reduce BaseModule to non-generic class implementing only OrchestratorModule without worker/dispatcher/lifecycle stubs; remove module auto-discovery call from worker and server startup sequences.
Shared session parsing utilities packages/core/src/utils/session-file.ts, packages/core/src/index.ts, packages/agent-worker/src/server.ts, packages/server/src/gateway/routes/public/agent-history.ts	Create packages/core/src/utils/session-file.ts with SessionEntry/ParsedMessage types and parseSessionEntries()/entryToMessage() functions; export from core index; remove local session parsing implementations from agent-worker server and gateway agent-history route; both now use shared utilities for JSONL parsing and entry-to-message projection.
Type consolidation packages/server/src/gateway/auth/settings/token-service.ts, packages/server/src/gateway/routes/public/agent-config.ts, multiple auth provider modules	Move ModelOption import source from local module-system to @lobu/core; move PrefillSkill and PrefillMcp (formerly PrefillMcpServer) to be imported from @lobu/core; update SettingsTokenPayload.prefillMcpServers field type to use imported PrefillMcp; expand core index to re-export all module and session-file types alongside worker wire contracts.
Environment variable type guards packages/server/src/gateway/orchestration/base-deployment-manager.ts	Add string type checks: ORIGINAL_MESSAGE_TS requires platformMetadata.originalMessageTs to be a string (else falls back to messageId or empty); BOT_RESPONSE_TS requires platformMetadata.botResponseTs to be a string; teamId derives from validated.teamId or requires platformMetadata.teamId to be a string.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• lobu-ai/lobu#871: Both modify packages/agent-worker/src/openclaw/worker.ts execution flow (this PR removes module lifecycle setup; related PR adds Phase 5 transcript snapshot gating).
• lobu-ai/lobu#865: Both refactor worker↔gateway message types (MessagePayload/QueuedMessage); related PR builds on the updated contract to add runId and runJobToken to snapshot auth and hydration.

Suggested labels

skip-size-check, refactor

Poem

🐰 Types take flight from many homes to core,
Module data fades and lifecycles no more,
Wire contracts gleam, now shared by all,
Sessions parse as one throughout the hall,
Cleaner walls where simplicity stands tall!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and clearly summarizes the main breaking change (dropping unused module-lifecycle public types) and the key refactoring (consolidating wire and session-file utilities). It accurately reflects the multi-round simplification across core packages.
Description check	✅ Passed	The PR description is comprehensive and well-structured with a clear Summary section explaining the ~385 LOC net deletion, a detailed Breaking change section identifying all removed types and their lack of internal consumers, specific Other simplifications subsection covering hoisting, deduplication, and deletion work, and a Process section documenting the five-round spike approach. The Test plan section covers the essential checks (make typecheck, make build-packages, worker/gateway boot, message round-trip, release-please major bump detection).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/simplify-runtime-core

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/core/src/utils/session-file.ts`:
- Around line 120-128: The model_change branch currently builds content and
model strings directly from entry.provider and entry.modelId, which can produce
"undefined/..." values; update the logic in the model_change handler (the block
checking if (entry.type === "model_change") that returns id, type, content,
model, timestamp, isVerbose) to defensively handle missing fields: derive safe
values for provider and modelId (e.g., const providerSafe = entry.provider ?? ''
and const modelIdSafe = entry.modelId ?? ''), then build content and model using
only the defined parts (omit the slash if one side is empty or return a sensible
fallback like 'unknown' or an empty string) so content and model never contain
the literal "undefined". Ensure timestamp and isVerbose behavior is unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 43147c05-a060-400c-9831-5021a4d79e08

📥 Commits

Reviewing files that changed from the base of the PR and between 57cd312 and 676dc56.

📒 Files selected for processing (34)

• packages/agent-worker/src/__tests__/message-batcher.test.ts
• packages/agent-worker/src/gateway/gateway-integration.ts
• packages/agent-worker/src/gateway/message-batcher.ts
• packages/agent-worker/src/gateway/sse-client.ts
• packages/agent-worker/src/gateway/types.ts
• packages/agent-worker/src/index.ts
• packages/agent-worker/src/modules/lifecycle.ts
• packages/agent-worker/src/openclaw/worker.ts
• packages/agent-worker/src/server.ts
• packages/core/src/index.ts
• packages/core/src/modules.ts
• packages/core/src/types.ts
• packages/core/src/utils/session-file.ts
• packages/core/src/worker/transport.ts
• packages/core/src/worker/wire.ts
• packages/server/src/gateway/__tests__/base-deployment-grants.test.ts
• packages/server/src/gateway/__tests__/embedded-deployment.test.ts
• packages/server/src/gateway/__tests__/orchestration-harden.test.ts
• packages/server/src/gateway/auth/api-key-provider-module.ts
• packages/server/src/gateway/auth/bedrock/provider-module.ts
• packages/server/src/gateway/auth/chatgpt/chatgpt-oauth-module.ts
• packages/server/src/gateway/auth/claude/oauth-module.ts
• packages/server/src/gateway/auth/gemini/cli-module.ts
• packages/server/src/gateway/auth/provider-model-options.ts
• packages/server/src/gateway/auth/settings/token-service.ts
• packages/server/src/gateway/infrastructure/queue/queue-producer.ts
• packages/server/src/gateway/modules/module-system.ts
• packages/server/src/gateway/orchestration/base-deployment-manager.ts
• packages/server/src/gateway/orchestration/impl/embedded-deployment.ts
• packages/server/src/gateway/orchestration/message-consumer.ts
• packages/server/src/gateway/routes/public/agent-config.ts
• packages/server/src/gateway/routes/public/agent-history.ts
• packages/server/src/gateway/services/core-services.ts
• packages/server/src/gateway/services/platform-helpers.ts

💤 Files with no reviewable changes (6)

• packages/agent-worker/src/index.ts
• packages/agent-worker/src/modules/lifecycle.ts
• packages/agent-worker/src/gateway/gateway-integration.ts
• packages/agent-worker/src/openclaw/worker.ts
• packages/core/src/worker/transport.ts
• packages/core/src/types.ts

[coderabbitai]

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Handle potentially undefined provider or modelId in model_change entries.

If entry.provider or entry.modelId is undefined, the content/model strings become "undefined/modelId" or "provider/undefined", which would surface to API consumers.

🛡️ Proposed defensive handling

   if (entry.type === "model_change") {
+    const model = entry.provider && entry.modelId
+      ? `${entry.provider}/${entry.modelId}`
+      : entry.provider || entry.modelId || "unknown";
     return {
       id: entry.id,
       type: "model_change",
-      content: `${entry.provider}/${entry.modelId}`,
-      model: `${entry.provider}/${entry.modelId}`,
+      content: model,
+      model,
       timestamp: entry.timestamp,
       isVerbose: true,
     };
   }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/core/src/utils/session-file.ts` around lines 120 - 128, The
model_change branch currently builds content and model strings directly from
entry.provider and entry.modelId, which can produce "undefined/..." values;
update the logic in the model_change handler (the block checking if (entry.type
=== "model_change") that returns id, type, content, model, timestamp, isVerbose)
to defensively handle missing fields: derive safe values for provider and
modelId (e.g., const providerSafe = entry.provider ?? '' and const modelIdSafe =
entry.modelId ?? ''), then build content and model using only the defined parts
(omit the slash if one side is empty or return a sensible fallback like
'unknown' or an empty string) so content and model never contain the literal
"undefined". Ensure timestamp and isVerbose behavior is unchanged.