chore: task-setup task-start doc + bump owletto for per-context runner#910
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR bumps the ChangesOwletto Submodule Version Update
Task Script Documentation Enhancement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/owletto`:
- Line 1: The submodule pointer for packages/owletto references a SHA not
reachable from owletto/main; first merge the companion PR lobu-ai/owletto#192
into the upstream owletto repo, then update the submodule pointer in our repo to
the resulting commit on owletto/main (replace the gitlink SHA referenced by
packages/owletto with the new main SHA), commit that change and push; finally
re-run CI to verify the submodule now points to a reachable commit on
owletto/main.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 287c3a4a-9569-48e8-8e36-b1c503e3dfd6
📒 Files selected for processing (2)
packages/owlettoscripts/task-setup.sh
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- `scripts/task-setup.sh` header: document the parameterized `task-start` zsh function (cmd defaults to claude; `task-start foo codex` works too) instead of the old claude-only shape. The function itself lives in the user's ~/.zshrc; this is just the in-tree reference for new operators. - Bump `packages/owletto` to pick up the per-context port + cwd runner fix (owletto#?) so the menubar's Start button actually spawns the right server for `lobu context add ... --port N --cwd <path> --lifecycle managed` entries (i.e. task-setup-registered worktrees).
4bca4a0 to
7d2de17
Compare
Summary
packages/owlettoto pick up lobu-ai/owletto#192 — the menubar's Start button now spawns the right server forlobu context add ... --port N --cwd <path> --lifecycle managedentries (i.e. task-setup-registered worktrees), instead of always trying port 8787 +~/lobu.task-start/task-resumeshell-function template inscripts/task-setup.shheader: command is now a parameter (defaults toclaude), sotask-start fix-sse-leak codexortask-start fix-sse-leak zshwork without editing the function. Function itself lives in the operator's~/.zshrc; this is just the in-tree reference.Why
After
task-setupwrites a managed context for the worktree (port = e.g. 8789, cwd = the worktree root), the menubar already surfaced the row with a Start verb — but pressing Start spawned on 8787 in~/lobu, not the worktree's port/cwd. The Swift fix in owletto closes that loop; this PR is just the pointer bump + doc tweak.Test plan
make task-setup NAME=foo→lobu context use foo→ menubar Start → server boots on the worktree's PORT against the worktree as cwd.packages/owletto) must resolve to a SHA onmain. Confirmed pushed:feat/menubar-runner-contexton lobu-ai/owletto.Companion
lobu-ai/owletto#192 — the Swift change.
Summary by CodeRabbit
Chores
Documentation