Skip to content

chore: task-setup task-start doc + bump owletto for per-context runner#910

Merged
buremba merged 1 commit into
mainfrom
feat/menubar-runner-context
May 19, 2026
Merged

chore: task-setup task-start doc + bump owletto for per-context runner#910
buremba merged 1 commit into
mainfrom
feat/menubar-runner-context

Conversation

@buremba
Copy link
Copy Markdown
Member

@buremba buremba commented May 19, 2026

Summary

  • Bump packages/owletto to pick up lobu-ai/owletto#192 — the menubar's Start button now spawns the right server for lobu context add ... --port N --cwd <path> --lifecycle managed entries (i.e. task-setup-registered worktrees), instead of always trying port 8787 + ~/lobu.
  • Refresh the task-start / task-resume shell-function template in scripts/task-setup.sh header: command is now a parameter (defaults to claude), so task-start fix-sse-leak codex or task-start fix-sse-leak zsh work without editing the function. Function itself lives in the operator's ~/.zshrc; this is just the in-tree reference.

Why

After task-setup writes a managed context for the worktree (port = e.g. 8789, cwd = the worktree root), the menubar already surfaced the row with a Start verb — but pressing Start spawned on 8787 in ~/lobu, not the worktree's port/cwd. The Swift fix in owletto closes that loop; this PR is just the pointer bump + doc tweak.

Test plan

  • After merge, make task-setup NAME=foolobu context use foo → menubar Start → server boots on the worktree's PORT against the worktree as cwd.
  • Owletto PR merges first (or in parallel); this PR's submodule pin (packages/owletto) must resolve to a SHA on main. Confirmed pushed: feat/menubar-runner-context on lobu-ai/owletto.

Companion

lobu-ai/owletto#192 — the Swift change.

Summary by CodeRabbit

  • Chores

    • Updated a subproject reference to a newer revision to ensure the app builds and runs with the latest included changes.
  • Documentation

    • Improved shell helper setup instructions and examples so task-launching helpers accept and forward extra command arguments, making local workflow commands more flexible and predictable.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 777cbae0-41bf-4815-b617-e9b6fd653ca8

📥 Commits

Reviewing files that changed from the base of the PR and between 4bca4a0 and 7d2de17.

📒 Files selected for processing (2)
  • packages/owletto
  • scripts/task-setup.sh

📝 Walkthrough

Walkthrough

This PR bumps the packages/owletto submodule to a new commit SHA and updates scripts/task-setup.sh documentation to show task helper examples that forward optional command arguments via exec "${@:-claude}".

Changes

Owletto Submodule Version Update

Layer / File(s) Summary
Owletto submodule version bump
packages/owletto
The packages/owletto submodule commit pointer is updated to a new SHA.

Task Script Documentation Enhancement

Layer / File(s) Summary
Task script usage documentation
scripts/task-setup.sh
Commented ~/.zshrc task-start/task-resume examples now use exec "${@:-claude}" to forward optional extra arguments and the usage header shows task-start fix-sse-leak plus an optional-arguments variant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • lobu-ai/lobu#857: Updates the same packages/owletto submodule commit pointer.
  • lobu-ai/lobu#840: Also changes the packages/owletto submodule SHA.
  • lobu-ai/lobu#889: Overlaps on the packages/owletto submodule bump (different additional changes).

Poem

I’m a rabbit with a tiny git,
I nudge a SHA, then tweak a tip—
helpers learn to pass along,
commands now sing a flexible song,
hop on, the repo’s fit for sprint. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the two main changes: task-setup documentation update and owletto submodule bump for per-context runner functionality.
Description check ✅ Passed The description is comprehensive and well-structured with Summary, Why, Test plan, and Companion sections. However, the test plan checkboxes are not marked and some required template sections are missing or incomplete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/menubar-runner-context

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/owletto`:
- Line 1: The submodule pointer for packages/owletto references a SHA not
reachable from owletto/main; first merge the companion PR lobu-ai/owletto#192
into the upstream owletto repo, then update the submodule pointer in our repo to
the resulting commit on owletto/main (replace the gitlink SHA referenced by
packages/owletto with the new main SHA), commit that change and push; finally
re-run CI to verify the submodule now points to a reachable commit on
owletto/main.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 287c3a4a-9569-48e8-8e36-b1c503e3dfd6

📥 Commits

Reviewing files that changed from the base of the PR and between 125fb6b and 4bca4a0.

📒 Files selected for processing (2)
  • packages/owletto
  • scripts/task-setup.sh

Comment thread packages/owletto Outdated
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

- `scripts/task-setup.sh` header: document the parameterized `task-start`
  zsh function (cmd defaults to claude; `task-start foo codex` works too)
  instead of the old claude-only shape. The function itself lives in the
  user's ~/.zshrc; this is just the in-tree reference for new operators.
- Bump `packages/owletto` to pick up the per-context port + cwd runner
  fix (owletto#?) so the menubar's Start button actually spawns the
  right server for `lobu context add ... --port N --cwd <path>
  --lifecycle managed` entries (i.e. task-setup-registered worktrees).
@buremba buremba force-pushed the feat/menubar-runner-context branch from 4bca4a0 to 7d2de17 Compare May 19, 2026 12:39
@buremba buremba merged commit ac81fd7 into main May 19, 2026
3 of 4 checks passed
@buremba buremba deleted the feat/menubar-runner-context branch May 19, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants