chore(chart,docs): fix NOTES.txt ingress key + drop duplicate secrets block#890
Conversation
… block Two CodeRabbit follow-ups from PR #882: 1. charts/lobu/templates/NOTES.txt referenced .Values.ingress.host (singular), but the chart's values schema uses .Values.ingress.hosts (array). Fresh installs rendered the install URL as `https://` with an empty host. Now reads from `index .Values.ingress.hosts 0` when both ingress.enabled and at least one host are set, falls through to the port-forward hint otherwise. 2. packages/landing/.../kubernetes.mdx had the same `kubectl create secret` block twice — once under "Create secrets" and again later under "Install". The second copy is removed and replaced with a back-reference to the earlier section, so users aren't told to do the same thing twice. Verified by `helm install --dry-run --debug --generate-name` on both ingress.enabled=true (renders https://app.example.com) and ingress.enabled=false (renders port-forward).
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe PR updates the Helm chart NOTES template to render ingress application URLs from a list of configured hosts rather than a single host value, and clarifies in the Kubernetes deployment documentation that required Secrets must pre-exist in the target namespace before chart installation. ChangesKubernetes Deployment Configuration
Possibly related PRs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Two CodeRabbit follow-ups from PR #882:
charts/lobu/templates/NOTES.txtreferenced.Values.ingress.host(singular), but the chart's values schema uses.Values.ingress.hosts(array). Fresh installs rendered the install URL ashttps://with an empty host. Now reads fromindex .Values.ingress.hosts 0when bothingress.enabledis true and at least one host is set, falling through to the port-forward hint otherwise.packages/landing/.../kubernetes.mdxhad the samekubectl create secretblock twice. The second copy is removed and replaced with a back-reference to the earlier section.Verification
```
$ helm install --dry-run --debug --generate-name charts/lobu \
--set ingress.enabled=true --set 'ingress.hosts={app.example.com}' | grep 'Application URL' -A 1
Application URL:
https://app.example.com
$ helm install --dry-run --debug --generate-name charts/lobu \
--set ingress.enabled=false | grep 'Application URL' -A 1
Application URL:
kubectl port-forward svc/lobu-...-app 8787:8787
```
Test plan
make build-packagescleanmake typecheckcleanSummary by CodeRabbit
Documentation
Improvements