feat(web): sidebar UX pass — tooltips, inline loading, members link, dedicated client routes#723
Conversation
See owletto-web feat/sidebar-ux-pass: - Tooltips on inactive sidebar pills + icon-only buttons (Radix, app-wide provider). - Loader2 spinners next to sidebar section headers replacing "Loading..." text. - Members link in user dropdown so dismissing the invite card isn't a dead end. - Dedicated /$owner/clients/$clientKey detail + /$owner/clients/connect routes; redundant /clients listing deleted.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR advances the ChangesSubmodule Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/web`:
- Line 1: The submodule commit for packages/web is pinned to c48b5ae which is
not an ancestor of owletto-web/main; update the submodule pointer so it
references a commit reachable from owletto-web/main (or alternatively merge
c48b5ae into that branch then repin). To fix, fetch the submodule remote
(origin), checkout or find a commit on origin/main that is an ancestor of
owletto-web/main, update the packages/web gitlink to that reachable commit (or
merge c48b5ae into origin/main and then set the gitlink), and commit the
submodule change so CI’s hard drift rule passes. Ensure you update only the
submodule reference in packages/web and include the new commit SHA in the commit
message.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
buremba
changed the title
There was a problem hiding this comment.
♻️ Duplicate comments (1)
packages/web (1)
1-1:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winSubmodule pointer still fails drift reachability check.
Line 1 pins
d95b4812be069b87ad43dce027392a2e3828358c, and CI confirms this SHA is not reachable fromowletto-web/main. Re-pinpackages/webto a commit reachable from submoduleorigin/main(or merge this SHA into that branch first), otherwise the hard drift gate and deploy remain blocked.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/web` at line 1, The packages/web submodule pointer is pinned to commit d95b4812be069b87ad43dce027392a2e3828358c which is not reachable from owletto-web/main; update the submodule reference in packages/web to point at a commit that is reachable from the submodule's origin/main (or merge the pinned SHA into origin/main first) so CI's drift reachability check passes and the hard drift gate/deploy are unblocked; locate the submodule entry in the repository's gitmodules/submodule configuration and update the commit reference (or perform the merge in the submodule repo) accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@packages/web`:
- Line 1: The packages/web submodule pointer is pinned to commit
d95b4812be069b87ad43dce027392a2e3828358c which is not reachable from
owletto-web/main; update the submodule reference in packages/web to point at a
commit that is reachable from the submodule's origin/main (or merge the pinned
SHA into origin/main first) so CI's drift reachability check passes and the hard
drift gate/deploy are unblocked; locate the submodule entry in the repository's
gitmodules/submodule configuration and update the commit reference (or perform
the merge in the submodule repo) accordingly.
![codex-approver[bot]](https://avatars.githubusercontent.com/u/255265539?s=60&v=4){kind=small}
2 participants
Summary
A sweep of small UX gaps in the web sidebar and adjacent surfaces.
<Tooltip>always wraps; tooltip content renders only when inactive, avoiding remount).Loader2spinner next to the section header (Entities, Agents, All clients, Watchers, Connections, Devices). Layout doesn't shift when data arrives.<div>s. Now wrapped in<Link>to a new/$owner/clients/$clientKeydetail page that resolves the key and renders<ClientDetail>directly. Added/$owner/clients/connectwhich embeds<McpConnect>. Deleted the redundant/$owner/clientslisting — the sidebar is the list now.TooltipProviderto the app root, then converted icon-only-buttontitle=attrs to Radix Tooltip across agent-conversations (delete/cancel), watcher-detail (discard), json-renderer (edit/remove pencils, both card and table forms), view-in-knowledge-link (component-level so all icon-only call sites inherit), invite-members-card (dismiss), entity-row settings cog. Removed truly redundant titles where the label is already visible.Submodule branch:
feat/sidebar-ux-passinlobu-ai/owletto-web.Test plan
/$owner/members./$owner/clients/$keywith that client's detail; "Connect a client" link goes to the new connect page.Summary by CodeRabbit
Note: This release contains infrastructure updates with no visible end-user facing changes.