fix(server): drop duplicate getClientIp export in rate-limiter#699
Conversation
PR #694 restored the helper, but the merge of #693 left an earlier copy intact — esbuild errors out on `Multiple exports with the same name "getClientIp"` in src/gateway/utils/rate-limiter.ts, breaking `make build-packages` on main (typecheck + integration CI jobs cascade from there). Drop the older un-documented copy; keep the JSDoc'd one. No behavior change — the two implementations were functionally identical.
buremba
force-pushed
the
fix/rate-limiter-dup-export
branch
from
61838dd to
467e6df
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61838ddb36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "vite": "^6.0.0", | ||
| "vitest": "^2.1.8", | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
In checkouts where the packages/web submodule is initialized, the root workspaces: ["packages/*"] still makes @lobu/web part of the Bun workspace, but this lockfile now omits its workspace entry and all web-only dependencies (the diff drops the previous "packages/web" and "@lobu/web@workspace:packages/web" entries). Since bun install --help documents --frozen-lockfile as disallowing lockfile changes, CI or production installs with the submodule present will either fail because Bun must rewrite the lockfile or proceed without the committed web dependency graph being locked.
Useful? React with 👍 / 👎.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 participants
Surfaced by the WS9/WS10 sweep — PR #694 restored the helper but the merge of #693 left an earlier copy intact. esbuild fails
make build-packageswith:That cascades through
typecheckandintegrationon main. Drops the older un-documented copy, keeps the JSDoc'd one (functionally identical).make build-packages+bun run typecheckboth green locally.