Skip to content

fix: address unaddressed Codex review comments from #478 / #498 / #521#535

Merged
buremba merged 2 commits into
mainfrom
claude/review-pr-comments-r8pDH
May 5, 2026
Merged

fix: address unaddressed Codex review comments from #478 / #498 / #521#535
buremba merged 2 commits into
mainfrom
claude/review-pr-comments-r8pDH

Conversation

@buremba
Copy link
Copy Markdown
Member

@buremba buremba commented May 4, 2026

Summary

Sweeps a handful of unresolved Codex P1/P2 review threads from already-merged PRs (#478, #498, #521). Each call site below was verified against current main.

Changes

Verified-already-fixed (no change)

Test plan

  • make build-packages is green
  • Pre-commit Biome + tsc pass
  • CI green
  • Manual: confirm lobu run with invalid PORT still surfaces a helpful error
  • Manual: confirm an internal MCP tool call still hits the approval gate when no grant exists

https://claude.ai/code/session_01NLSbCEn2nJijWa6ZzhixYz


Generated by Claude Code

claude added 2 commits May 4, 2026 23:55
Sweeps a handful of unresolved review threads on already-merged PRs.

- task-scheduler (#478): retry seedNextCronTick in the background after
  boot-time failures so a transient DB hiccup doesn't permanently idle a
  periodic task until the next pod restart.

- mcp/proxy (#498): forward the worker JWT into getToolAnnotations so
  internal MCP tool discovery (lobu-memory) doesn't go upstream
  unauthenticated, return empty, and silently bypass requiresToolApproval.

- mcp/config-service (#498): preserve a manually configured lobu-memory
  MCP entry when deriveLobuMemoryServer returns null (transient DB error).
  Only drop entries that were derived (internal === true).

- cli/dev (#521): clear CodeQL clear-text-logging alerts by logging the
  validated portNum instead of the raw env-sourced port string.
Pre-commit hook reformat that was missed in the prior commit.
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/commands/dev.ts 0.00% 11 Missing ⚠️

📢 Thoughts on this report? Let us know!

@buremba buremba enabled auto-merge (squash) May 5, 2026 00:02
@buremba buremba merged commit 1c704f0 into main May 5, 2026
16 checks passed
@buremba buremba deleted the claude/review-pr-comments-r8pDH branch May 5, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants