fix: address unaddressed Codex review comments from #478 / #498 / #521#535
Merged
Conversation
Sweeps a handful of unresolved review threads on already-merged PRs. - task-scheduler (#478): retry seedNextCronTick in the background after boot-time failures so a transient DB hiccup doesn't permanently idle a periodic task until the next pod restart. - mcp/proxy (#498): forward the worker JWT into getToolAnnotations so internal MCP tool discovery (lobu-memory) doesn't go upstream unauthenticated, return empty, and silently bypass requiresToolApproval. - mcp/config-service (#498): preserve a manually configured lobu-memory MCP entry when deriveLobuMemoryServer returns null (transient DB error). Only drop entries that were derived (internal === true). - cli/dev (#521): clear CodeQL clear-text-logging alerts by logging the validated portNum instead of the raw env-sourced port string.
Pre-commit hook reformat that was missed in the prior commit.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sweeps a handful of unresolved Codex P1/P2 review threads from already-merged PRs (#478, #498, #521). Each call site below was verified against current
main.Changes
task-scheduler.ts(feat(scheduler): unified TaskScheduler — replace setInterval maintenance loop #478) —start()previously logged + swallowedseedNextCronTickfailures, so a transient DB hiccup at boot could leave a periodic task permanently idle until the next pod restart (no self-seed path). Now retries in the background at 5s / 15s / 60s before giving up.gateway/auth/mcp/proxy.ts(fix: harden lobu memory watcher reliability #498) —getToolAnnotationsdid not forward the worker JWT tofetchToolsForMcp, so uncachedtools/listdiscovery for internal MCPs (lobu-memory) went upstream unauthenticated, returned an empty list, and silently bypassedrequiresToolApproval(found=falsewas treated as "no approval needed"). Forwardsauth.token/sessionTokenthrough both call sites.gateway/auth/mcp/config-service.ts(fix: harden lobu memory watcher reliability #498) —getEffectiveAgentMcpServerspreviously deleted thelobu-memoryentry wheneverderiveLobuMemoryServerreturnednull(transient DB error, slug not yet resolvable). A manually configuredlobu-memoryserver in agent settings would silently disappear. Now only drops the entry when it was derived (internal === true).cli/commands/dev.ts(feat(cli): non-interactive init, REPL chat, project link, beefier doctor #521) — Clears CodeQL clear-text-logging alerts (chore(main): release lobu 3.7.0 #228, fix(ci): initialize owletto-web submodule in landing deploy #229, fix: ship app.lobu.ai SPA + retire owletto.com defaults #230, feat(owletto): absorb skills, benchmarks, and dev scripts from owletto repo #231) by logging the validatedportNuminstead of the raw env-sourced port string.Verified-already-fixed (no change)
claimed_at < now() - ORPHANED_CLAIM_THRESHOLD.lobu apply --urltoken resolution and per-context active org are already wired correctly.resolveServerUrlwere addressed by later refactors (refactor: unify connection storage on agent_connections, drop chat_connections #506).WHERE watcher_id = groupId.Test plan
make build-packagesis greenlobu runwith invalidPORTstill surfaces a helpful errorhttps://claude.ai/code/session_01NLSbCEn2nJijWa6ZzhixYz
Generated by Claude Code