chore: bump owletto pointer + fix unit job CLI dist build#1126
Conversation
The cli-ux unit test spawns `packages/cli/bin/lobu.js memory browser-auth
--help`. The bin shim resolves `../dist/index.js` at runtime; without a
prior build the resolver fails with `Cannot find module '../dist/index.js'`
and the test fails on `expect(out).toContain("--connector")` because the
spawned subprocess never started.
Local invocation of the bin worked because make build-packages had run;
CI's unit job builds core/connector-sdk/embeddings/connector-worker but
not cli, so the bin was always broken under CI. Add cli to the build list.
|
Warning Review limit reached
More reviews will be available in 3 minutes and 14 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 participants
Two tiny pre-existing CI fixes surfaced while triaging #1121's red checks (both are red on `main` too, so this is hygiene, not regression).
1. `chore(submodule)`: bump owletto pointer to current main
`check-drift` flags that the lobu parent pins `a317d4e` but `owletto/main` has moved on to `6bcdb9c` (one extension fix + two image bumps already merged on owletto's side). Per CLAUDE.md "bump the lobu submodule pointer as a separate PR" — this is that PR.
2. `ci(unit)`: build cli dist before running bin/lobu unit tests
The cli-ux unit test spawns `packages/cli/bin/lobu.js memory browser-auth --help`. The bin shim resolves `../dist/index.js` at runtime; without a prior build the resolver fails with:
```
error: Cannot find module '../dist/index.js' from '/home/runner/work/lobu/lobu/packages/cli/bin/lobu.js'
```
…and the test fails the `expect(out).toContain("--connector")` assertion because the spawned subprocess never started. CI's unit job builds core / connector-sdk / embeddings / connector-worker but not cli; add cli to that list.
Test plan
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.