chore(server): drop pre-#902 bootstrap-user filters, dead env vars, legacy enc:v1: decoder

[buremba]

Summary

Aggressive cleanup pass on packages/server removing pre-PR #902 / pre-#965 legacy and dead env vars (no backwards-compat shims):

• Pre-feat(server): drop bootstrap-user, first /sign-up becomes the install's identity #902 bootstrap-user row filters dropped

  • auth/config.ts hasUser: drop AND id <> 'bootstrap-user'
  • auth/routes.ts /local-init: drop WHERE id <> 'bootstrap-user' (and the surrounding pre-PR feat(server): drop bootstrap-user, first /sign-up becomes the install's identity #902 comment)
  • auth/index.tsx single-user signup guard: drop the id ne 'bootstrap-user' clause from countTotalUsers
  • single-user-signup.test.ts: drop the corresponding bootstrap-user seeded case; renamed test reads "does not count install_operator as the existing human"

• Legacy enc:v1: encrypted-config decoder deleted (lobu/stores/postgres-stores.ts)

  • Removed ENC_PREFIX, decryptLegacyEncryptedConfig, and the now-unused decrypt import. rowToConnection reads row.config ?? {} straight through.
  • Prod evidence: connections WHERE config::text LIKE '%enc:v1:%' returns 0 rows.

• Dead SOCKET_* env vars + health: {...} config block removed (gateway/config/index.ts)

  • SOCKET_HEALTH_CHECK_INTERVAL_MS / SOCKET_STALE_THRESHOLD_MS / SOCKET_PROTECT_ACTIVE_WORKERS had zero consumers anywhere in packages/.
  • Matching test mock cleaned up (core-services-store-selection.test.ts).

• .env.example cleanup

  • Dropped the SOCKET_* block and the Slack manifest-sync block (SLACK_CONFIG_TOKEN, SLACK_CONFIG_REFRESH_TOKEN, SLACK_APP_ID) — all unreferenced.

• Dead re-exports / privatized internal consts (gateway/guardrails/)

  • guardrails/index.ts: dropped re-exports of BUILTIN_GUARDRAIL_FACTORIES, _resetSharedJudgeForTests, _setSharedJudgeForTests
  • guardrails/builtins.ts: removed export from secretScanGuardrail and forbiddenToolsGuardrail (only used via the in-file factory map + registerBuiltinGuardrails)

• Dead deps removed (packages/server/package.json): commander, yaml (zero source refs). bun install regenerated bun.lock.

• Broken/orphaned test removed: gateway/routes/public/__tests__/settings-auth.test.ts was failing on stale expectations and would be cleaned up by knip.

• Stale Phase 5 comments: cleaned in embedded-deployment.ts.

Validation

• bunx tsc --noEmit in packages/server: clean
• bun run typecheck at root: clean
• bunx vitest run packages/server/src/__tests__/integration/auth/single-user-signup.test.ts: 3/3 pass against ephemeral embedded Postgres
• bun test packages/server/src/gateway/__tests__/core-services-store-selection.test.ts: 2/2 pass
• bunx vitest run packages/server/src/__tests__/guardrails-runtime.test.ts: 8/8 pass
• make build-packages: success

Test plan

• Typecheck (root + per-package)
• Touched integration tests pass
• Build succeeds
• make review BASE=origin/main verdict

---

^{Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.}

[coderabbitai]

Warning

Review limit reached

@buremba, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 7 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 159ff929-a931-488b-8443-6c64445e7117

📥 Commits

Reviewing files that changed from the base of the PR and between da2cfee and 25cde29.

⛔ Files ignored due to path filters (1)

• bun.lock is excluded by !**/*.lock

📒 Files selected for processing (13)

• .env.example
• docs/install-operator-bootstrap.md
• packages/server/package.json
• packages/server/src/__tests__/integration/auth/single-user-signup.test.ts
• packages/server/src/auth/config.ts
• packages/server/src/auth/index.tsx
• packages/server/src/auth/routes.ts
• packages/server/src/gateway/__tests__/core-services-store-selection.test.ts
• packages/server/src/gateway/__tests__/settings-auth.test.ts
• packages/server/src/gateway/config/index.ts
• packages/server/src/gateway/guardrails/builtins.ts
• packages/server/src/gateway/guardrails/index.ts
• packages/server/src/lobu/stores/postgres-stores.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/server-legacy-cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[buremba]

bug_free 84, simplicity 88, slop 15, bugs 0, 0 blockers

Read diff and script logs: typecheck, unit, and integration all passed. Explored by booting bundled server with DATABASE_URL=file:///tmp/lobu-review-server-db and hitting /health -> 200. Main concern is removal of 464 settings-auth security tests without replacement plus stale bootstrap-user docs/comments.

Suggested fixes

File	Line	Change
packages/server/src/gateway/routes/public/__tests__/settings-auth.test.ts	1	Restore these settings-auth hardening regression tests, or move equivalent coverage for token validation, cookie flags, and session fallback into an existing test file.
packages/server/src/auth/routes.ts	510	Update the trust-model comment to remove the stale claim that legacy bootstrap-user rows count as zero via an id filter.
docs/install-operator-bootstrap.md	52	Update the bootstrap-user carve-out documentation to match the removed filters, including the later references at lines 164-179.

Full verdict JSON

{
  "bug_free_confidence": 84,
  "bugs": 0,
  "slop": 15,
  "simplicity": 88,
  "blockers": [],
  "change_type": "chore",
  "behavior_change_risk": "medium",
  "tests_adequate": false,
  "suggested_fixes": [
    {
      "file": "packages/server/src/gateway/routes/public/__tests__/settings-auth.test.ts",
      "line": 1,
      "change": "Restore these settings-auth hardening regression tests, or move equivalent coverage for token validation, cookie flags, and session fallback into an existing test file."
    },
    {
      "file": "packages/server/src/auth/routes.ts",
      "line": 510,
      "change": "Update the trust-model comment to remove the stale claim that legacy bootstrap-user rows count as zero via an id filter."
    },
    {
      "file": "docs/install-operator-bootstrap.md",
      "line": 52,
      "change": "Update the bootstrap-user carve-out documentation to match the removed filters, including the later references at lines 164-179."
    }
  ],
  "notes": "Read diff and script logs: typecheck, unit, and integration all passed. Explored by booting bundled server with DATABASE_URL=file:///tmp/lobu-review-server-db and hitting /health -> 200. Main concern is removal of 464 settings-auth security tests without replacement plus stale bootstrap-user docs/comments.",
  "categories": {
    "src": 101,
    "tests": 480,
    "docs": 0,
    "config": 14,
    "deps": 24,
    "migrations": 0,
    "ci": 0,
    "generated": 0
  }
}

Local review gate — branch protection can require the pi-review commit status. See docs/REVIEW_SCHEMA.md.