chore: drop stale PGlite references + vestigial workaround comments#1119
Conversation
|
Warning Review limit reached
More reviews will be available in 3 minutes and 11 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (17)
📝 WalkthroughWalkthroughThis PR updates terminology throughout the Lobu codebase, replacing references to "PGlite" with "embedded Postgres" (PG18 with pgvector) to reflect the default bundled database for scaffolded projects. Changes span CLI build scripts, landing documentation, server infrastructure comments, and a subproject version bump. No executable logic or functional behavior has been modified. ChangesTerminology update: PGlite to embedded Postgres
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/landing/src/content/docs/guides/troubleshooting.md`:
- Line 6: The landing copy contains em dashes that must be removed in
user-facing text; update the sentences in the described markdown (the line
containing "so `DATABASE_URL` is optional — set it only when you want an
external Postgres..." and the other affected line at 143) by replacing the em
dash (—) with appropriate punctuation (e.g., a comma, period, or parentheses) so
the text reads naturally without em dashes; edit the markdown lines in
packages/landing/src/content/docs/guides/troubleshooting.md accordingly (locate
the sentence with "start-local.bundle.mjs" / "server.bundle.mjs" and the
sentence at line 143) and ensure grammar/spacing remains correct after the
replacement.
In `@packages/owletto`:
- Line 1: The submodule commit for packages/owletto is pointing to a SHA that is
not reachable from owletto/main and fails the Submodule Drift CI; re-pin the
submodule to a commit that exists on owletto/main (or merge/cherry-pick the
desired change into owletto/main), then update the gitlink for packages/owletto
to that reachable SHA: check out the owletto subrepo, identify a valid commit on
owletto/main (e.g., via git fetch && git log origin/main), update the submodule
reference in the parent repo (using git submodule update --init && git submodule
set-branch --branch main packages/owletto and git add packages/owletto followed
by git commit) or set the gitlink to the new SHA, and push the parent repo so CI
sees the corrected submodule SHA.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 407296cc-7745-4578-804d-44338f90aa04
📒 Files selected for processing (15)
packages/cli/scripts/build.cjspackages/cli/src/__tests__/dev.test.tspackages/landing/src/content/docs/getting-started/comparison.mdpackages/landing/src/content/docs/getting-started/index.mdxpackages/landing/src/content/docs/guides/architecture.mdxpackages/landing/src/content/docs/guides/troubleshooting.mdpackages/landing/src/content/docs/reference/cli.mdpackages/owlettopackages/server/scripts/build-server-bundle.mjspackages/server/src/__tests__/setup/embedded-postgres-backend.tspackages/server/src/__tests__/setup/test-db.tspackages/server/src/auth/index.tsxpackages/server/src/gateway/__tests__/turn-liveness.test.tspackages/server/src/gateway/orchestration/turn-liveness.tspackages/server/vitest.config.ts
| --- | ||
|
|
||
| Lobu boots as a single Node process: `lobu run`. A scaffolded project defaults to an **in-process PGlite** database (entry `start-local.bundle.mjs`), so `DATABASE_URL` is optional — set it only when you want an external Postgres (with pgvector), in which case the entry is `server.bundle.mjs`. The monorepo `make dev` always requires `DATABASE_URL`. Worker subprocesses are spawned by the gateway's `EmbeddedDeploymentManager`. There is no Redis. | ||
| Lobu boots as a single Node process: `lobu run`. A scaffolded project defaults to an **embedded Postgres** (PG18 + pgvector, entry `start-local.bundle.mjs`), so `DATABASE_URL` is optional — set it only when you want an external Postgres, in which case the entry is `server.bundle.mjs`. The monorepo `make dev` always requires `DATABASE_URL`. Worker subprocesses are spawned by the gateway's `EmbeddedDeploymentManager`. There is no Redis. |
There was a problem hiding this comment.
Replace em dashes in landing copy on these updated lines.
Please replace — with alternative punctuation (e.g., comma/period/parentheses) in the changed user-facing text at Line 6 and Line 143.
As per coding guidelines, "Remove em dashes from user-facing text in landing copy".
Also applies to: 143-143
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/landing/src/content/docs/guides/troubleshooting.md` at line 6, The
landing copy contains em dashes that must be removed in user-facing text; update
the sentences in the described markdown (the line containing "so `DATABASE_URL`
is optional — set it only when you want an external Postgres..." and the other
affected line at 143) by replacing the em dash (—) with appropriate punctuation
(e.g., a comma, period, or parentheses) so the text reads naturally without em
dashes; edit the markdown lines in
packages/landing/src/content/docs/guides/troubleshooting.md accordingly (locate
the sentence with "start-local.bundle.mjs" / "server.bundle.mjs" and the
sentence at line 143) and ensure grammar/spacing remains correct after the
replacement.
Post-#965 (embedded-postgres replacing PGlite), several comment blocks still referenced PGlite-era constraints that no longer apply. Cleans up landing docs, code comments, test docstrings, and removes the historical justifications for the auth/index.tsx ctx.internalAdapter deadlock-avoidance pattern and the turn-liveness.ts literal-queue-name workaround. The code itself is unchanged; only stale narrative is gone.
buremba
force-pushed
the
feat/pglite-cleanup
branch
from
aaf0f7f to
3865ad7
Compare
2 participants
Summary
Post-#965 (embedded-postgres replacing PGlite), several comment blocks still referenced PGlite-era constraints that no longer apply. This sweep cleans up:
Code unchanged — purely stale-narrative removal. Paired with owletto#239 (Chrome extension comment fix); submodule pointer bumped here.
Test plan
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by CodeRabbit
DATABASE_URLis optional for local runs but required for monorepo development.