chore: bump packages/owletto pointer to ad46ebf#1089
Conversation
Picks up: fix(mac): open menu-bar deep-links as plain web URLs (#232) Before: d940389 After: ad46ebf
📝 WalkthroughWalkthroughThis PR updates the ChangesSubmodule Pointer Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/owletto`:
- Line 1: The submodule pointer for packages/owletto is currently set to commit
ad46ebf725ab7393bf010e1630c73bae0eced3a6 which is not reachable from
owletto/main; update the packages/owletto gitlink to point to a commit that
exists on owletto/main (or rebase/merge the upstream owletto/main so that the
pinned SHA becomes reachable) before merging. Locate the submodule entry
(packages/owletto) in the repository index or .gitmodules and change the
gitlink/commit to a valid HEAD on owletto/main, or adjust your PR order so the
target commit is pushed to the owletto remote branch owletto/main first, then
update the pointer to that commit and re-run git submodule sync/update.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| @@ -1 +1 @@ | |||
| Subproject commit d9403899c3747a9f975923ada795108b130055f4 | |||
| Subproject commit ad46ebf725ab7393bf010e1630c73bae0eced3a6 | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the new submodule SHA is reachable from owletto/main
cd packages/owletto
git fetch origin main
PINNED="ad46ebf725ab7393bf010e1630c73bae0eced3a6"
if git merge-base --is-ancestor "$PINNED" origin/main; then
echo "✓ SHA $PINNED is reachable from owletto/main"
exit 0
else
echo "✗ SHA $PINNED is NOT reachable from owletto/main"
echo "This violates the deployment safety rule."
exit 1
fiRepository: lobu-ai/lobu
Length of output: 504
Critical: Ensure the owletto submodule pin commit is on owletto/main before merging.
ad46ebf725ab7393bf010e1630c73bae0eced3a6 is not reachable from owletto/main in the packages/owletto submodule (git merge-base --is-ancestor ... origin/main fails; fetch also reports not our ref). This violates the deployment safety rule that the parent must never pin a SHA not present on owletto/main. Update the submodule pointer to a commit that exists on owletto/main (or adjust PR sequencing).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/owletto` at line 1, The submodule pointer for packages/owletto is
currently set to commit ad46ebf725ab7393bf010e1630c73bae0eced3a6 which is not
reachable from owletto/main; update the packages/owletto gitlink to point to a
commit that exists on owletto/main (or rebase/merge the upstream owletto/main so
that the pinned SHA becomes reachable) before merging. Locate the submodule
entry (packages/owletto) in the repository index or .gitmodules and change the
gitlink/commit to a valid HEAD on owletto/main, or adjust your PR order so the
target commit is pushed to the owletto remote branch owletto/main first, then
update the pointer to that commit and re-run git submodule sync/update.
Bumps
packages/owlettopointer.Picks up: fix(mac): open menu-bar deep-links as plain web URLs (#232)
Summary by CodeRabbit