-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 style(ui): Confirmation when adding a new topic
#3030
base: main
Are you sure you want to change the base?
Conversation
@RubuJam is attempting to deploy a commit to the LobeHub Pro Team on Vercel. A member of the Team first needs to authorize it. |
👍 @RubuJam Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3030 +/- ##
==========================================
+ Coverage 93.40% 93.87% +0.46%
==========================================
Files 380 386 +6
Lines 23477 23824 +347
Branches 1786 1765 -21
==========================================
+ Hits 21929 22364 +435
+ Misses 1548 1460 -88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@arvinxx Please review |
); | ||
if (mobile) { | ||
return ( | ||
<Popconfirm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mobile 上不要用 Popconfirm 吧,这个有点太小了。换成 Modal .confirm
好一些。另外逻辑写在 onClick 里,不建议再单独提一个 组件 Render 出来
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
在移动端点击
将当前会话保存为话题
时,会进行弹窗进行二次确认,避免误触在移动设备上,话题列表中的
MoreVertical
图标将会始终显示Upon selecting the option to "Save current conversation as topic" on the mobile terminal, a pop-up window will be displayed for secondary confirmation, thus preventing any potential accidental touches.
In the context of mobile devices, the "MoreVertical" icon will invariably be present within the topic list.
📝 补充信息 | Additional Information
close #2717
![photo](https://private-user-images.githubusercontent.com/36145660/342623129-07405e43-d1ee-4696-9d36-ff58ea0d2de7.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAzOTIyOTMsIm5iZiI6MTcyMDM5MTk5MywicGF0aCI6Ii8zNjE0NTY2MC8zNDI2MjMxMjktMDc0MDVlNDMtZDFlZS00Njk2LTlkMzYtZmY1OGVhMGQyZGU3LlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA3VDIyMzk1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMyNGQzMTAyYzY5Y2Y2ZTFmNzhlNWE0NDJlZDIzZjNhOWMyNGM1MDBiYWM1ZjYzNWMxNDgxNjdiNjI3ODE3ZWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.SbPbJ0yN9y_cJcqO_AwfSTWx6QABPDsc9avUhu_NDvY)