Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style(ui): Confirmation when adding a new topic #3030

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented Jun 25, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

在移动端点击将当前会话保存为话题时,会进行弹窗进行二次确认,避免误触

在移动设备上,话题列表中的MoreVertical图标将会始终显示

Upon selecting the option to "Save current conversation as topic" on the mobile terminal, a pop-up window will be displayed for secondary confirmation, thus preventing any potential accidental touches.

In the context of mobile devices, the "MoreVertical" icon will invariably be present within the topic list.

📝 补充信息 | Additional Information

close #2717
photo

topic

Copy link

vercel bot commented Jun 25, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.87%. Comparing base (1a067b1) to head (a63f0ac).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3030      +/-   ##
==========================================
+ Coverage   93.40%   93.87%   +0.46%     
==========================================
  Files         380      386       +6     
  Lines       23477    23824     +347     
  Branches     1786     1765      -21     
==========================================
+ Hits        21929    22364     +435     
+ Misses       1548     1460      -88     
Flag Coverage Δ
app 93.87% <ø> (+0.46%) ⬆️
server 68.03% <ø> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RubuJam
Copy link
Contributor Author

RubuJam commented Jun 25, 2024

@arvinxx Please review

);
if (mobile) {
return (
<Popconfirm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile 上不要用 Popconfirm 吧,这个有点太小了。换成 Modal .confirm 好一些。另外逻辑写在 onClick 里,不建议再单独提一个 组件 Render 出来

Copy link
Contributor Author

@RubuJam RubuJam Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile上的即将清空当前会话消息,清空后将无法找回,请确认你的操作也是用的Popconfirm,实际效果也还可以,我倾向于不换,而且现在的布局更方便用户单手操作,如果有必要换,那我就去改

这是现在的显示效果image

@RubuJam RubuJam requested a review from arvinxx July 1, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] IOS端浏览器访问-“将当前会话保存为话题”不可用
3 participants