Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(package): Add support for missing version #25

Merged
merged 7 commits into from
Aug 29, 2017
Merged

feat(package): Add support for missing version #25

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
884fe76
feat(package): Add support for missing version
ffflorian Aug 24, 2017
76b3463
style(package): Display only the date when version is missing
ffflorian Aug 25, 2017
2d93cc4
fix(package): no version should be 'null', not 'false'.
ffflorian Aug 28, 2017
695f757
test: Added tests for writer and package
ffflorian Aug 28, 2017
6ce9854
other(package): Added space before parentheses
ffflorian Aug 28, 2017
b3e0bc8
other: review changes
ffflorian Aug 29, 2017
6fb68b1
chore: merge from master
ffflorian Aug 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ exports.calculateNewVersion = function (options) {
options = options || {};
return exports.getUserPackage()
.then(function (userPackage) {
if (!userPackage.version) {
return false;
}

var split = userPackage.version.split('.');

if (options.major) {
Expand Down
6 changes: 5 additions & 1 deletion lib/writer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ exports.markdown = function (version, commits, options) {
heading = '####';
}

heading += ' ' + version + ' (' + date + ')';
if (version) {
heading += ' ' + version + ' (' + date + ')';
} else {
heading += ' ' + date;
}

content.push(heading);
content.push('');
Expand Down