-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(package): Add support for missing version #25
Changes from 5 commits
884fe76
76b3463
2d93cc4
695f757
6ce9854
b3e0bc8
6fb68b1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -147,6 +147,16 @@ describe('package', function () { | |
Expect(version).to.eql('1.2.3'); | ||
}); | ||
}); | ||
|
||
it('returns null if no version is specified', function () { | ||
Package.getUserPackage.restore(); | ||
Sinon.stub(Package, 'getUserPackage').returns(Bluebird.resolve({ version: '' })); | ||
|
||
return Package.calculateNewVersion() | ||
.then(function (version) { | ||
Expect(version).to.eql(null); | ||
}); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit pick: can you add a new line after this |
||
}); | ||
|
||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,17 @@ describe('writer', function () { | |
}); | ||
}); | ||
|
||
it('keeps only the date if no version is specified', function () { | ||
var options = { major: true }; | ||
|
||
return Writer.markdown(false, [], options) | ||
.then(function (changelog) { | ||
var heading = changelog.split('\n')[0]; | ||
|
||
Expect(heading).to.equal('## ' + new Date().toJSON().slice(0,10)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit pick: can you add a space after the comma in the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually I copied this from writer.js but I see that you updated it with the new lint version :) |
||
}); | ||
}); | ||
|
||
it('flushes out a commit type with its full name', function () { | ||
var commits = [ | ||
{ type: 'feat', category: 'testing', subject: 'did some testing', hash: '1234567890' } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit pick: can you change this to
.to.be.null;
. We prefer to use the chai shorthands whenever possible.