feat: notify admin to update solvers in the community #618

Anyitechs · 2024-12-20T13:05:54Z

This PR schedules a daily job at midnight to notify the admin of a community that there are no solvers in the community. The maximum number of notification messages right now is set to 5, afterwards the community is disabled.

Fixes #314

Catrya

Hello, did you tested it locally? It's not working properly:

This message is not being displayed: Your community ${community.name} doesn't have any solvers. Please add at least one solver to avoid being disabled.
Even though the logs say: Community: ${community.name} has been disabled due to lack of solvers. the community is not being disabled. You can continue using it normally.
I recommend putting the warning messages to the administrators in the language they have the bot set in, in the yaml of ./locales. You can see as an example at Add cronjob to notify admin about missing solvers (#314) #563

Anyitechs · 2024-12-22T06:02:57Z

Hello, did you tested it locally? It's not working properly:

This message is not being displayed: Your community ${community.name} doesn't have any solvers. Please add at least one solver to avoid being disabled.

Even though the logs say: Community: ${community.name} has been disabled due to lack of solvers. the community is not being disabled. You can continue using it normally.

I recommend putting the warning messages to the administrators in the language they have the bot set in, in the yaml of ./locales. You can see as an example at Add cronjob to notify admin about missing solvers (#314) #563

Thank you for the review. I'll work on these feedbacks.

…sages are localized

Anyitechs · 2025-01-03T17:45:53Z

Hi @Catrya, I've addressed all the feedbacks here. Please have a look and let me know if there're other changes.

Hello, did you tested it locally? It's not working properly:

This message is not being displayed: Your community ${community.name} doesn't have any solvers. Please add at least one solver to avoid being disabled.

Even though the logs say: Community: ${community.name} has been disabled due to lack of solvers. the community is not being disabled. You can continue using it normally.

I recommend putting the warning messages to the administrators in the language they have the bot set in, in the yaml of ./locales. You can see as an example at Add cronjob to notify admin about missing solvers (#314) #563

Catrya

Hi @Anyitechs , much better, it already sends messages to the admins and disables the community. However, I think the message for the admins could be improved so that they know how much time they have to put a new admin.
I think it could be something like this:

Your community ${communityName} does not have any solvers. Please add at least one within X days to prevent the community from being disabled.

Actually the number of notifications that the solver receives before disabling the community is MAX_MESSAGES -1 because it disables it in MAX_MESSAGES, I suggest that it shows that number of notifications before disabling it

I will continue testing and I will tell you if I find any bug, good job!

Anyitechs · 2025-01-09T11:49:31Z

Hi @Anyitechs , much better, it already sends messages to the admins and disables the community. However, I think the message for the admins could be improved so that they know how much time they have to put a new admin. I think it could be something like this:

Your community ${communityName} does not have any solvers. Please add at least one within X days to prevent the community from being disabled.

Actually the number of notifications that the solver receives before disabling the community is MAX_MESSAGES -1 because it disables it in MAX_MESSAGES, I suggest that it shows that number of notifications before disabling it

I will continue testing and I will tell you if I find any bug, good job!

Thank you for the feedback @Catrya. I just pushed a new commit with the changes requested here. Please take a look and let me know your thoughts. Thank you.

Catrya

ACK. Thanks @Anyitechs !

Catrya

Hi @Anyitechs, sorry but I remembered that when a community is disabled it should also be deleted from the database, see deleteCommunity
This PR does not delete the community from the database, and I think that is necessary.
Anyway, let's see what @grunch thinks, sorry

Anyitechs · 2025-01-20T10:56:57Z

Hi @Anyitechs, sorry but I remembered that when a community is disabled it should also be deleted from the database, see deleteCommunity This PR does not delete the community from the database, and I think that is necessary. Anyway, let's see what @grunch thinks, sorry

Thank you @Catrya. I was thinking we needed a soft delete and that was why I added the is_disabled flag to the community model. But why do we need to disable a community first and also delete it from the database. Why don't we go ahead and delete the community rather than having to disable it first?

Any thoughts? @grunch

Catrya · 2025-01-20T14:11:49Z

Thank you @Catrya. I was thinking we needed a soft delete and that was why I added the is_disabled flag to the community model. But why do we need to disable a community first and also delete it from the database. Why don't we go ahead and delete the community rather than having to disable it first?

Any thoughts? @grunch

Hi @Anyitechs , I don't mean to disable it first and then delete it, but to delete it.
Send messages to users as you already do, but if admin doesn't add a solver, just delete it from the database (we already called that disabling)

Anyitechs · 2025-01-20T14:55:32Z

Thank you @Catrya. I was thinking we needed a soft delete and that was why I added the is_disabled flag to the community model. But why do we need to disable a community first and also delete it from the database. Why don't we go ahead and delete the community rather than having to disable it first?
Any thoughts? @grunch

Hi @Anyitechs , I don't mean to disable it first and then delete it, but to delete it. Send messages to users as you already do, but if admin doesn't add a solver, just delete it from the database (we already called that disabling)

That makes sense. Thank you for the clarification. I'll work on that and update the branch.

Anyitechs · 2025-01-20T15:44:11Z

@Catrya I just pushed an update to the branch now. Please do take a look and let me know your thoughts. Thank you.

Catrya

thanks @Anyitechs I already tested it and it works well to me! Let's see @grunch review

Anyitechs · 2025-01-21T06:31:38Z

thanks @Anyitechs I already tested it and it works well to me! Let's see @grunch review

Thank you @Catrya. @grunch let me know if there're any changes. Thank you.

grunch · 2025-01-23T13:44:45Z

bot/modules/community/commands.js

@@ -143,7 +143,7 @@ exports.updateCommunity = async (ctx, id, field, bot) => {
    if (!(await validateObjectId(ctx, id))) return;
    const community = await Community.findOne({
      _id: id,
-      creator_id: user._id,


as you can read in our contribution section, we are using the airbnb javascript guide style, please don't remove the comma

https://github.com/airbnb/javascript?tab=readme-ov-file#commas--dangling

Adding them back now.

grunch · 2025-01-23T13:45:03Z

bot/modules/community/commands.js

@@ -211,7 +211,7 @@ exports.deleteCommunity = async ctx => {
    if (!(await validateObjectId(ctx, id))) return;
    const community = await Community.findOne({
      _id: id,
-      creator_id: ctx.user._id,
+      creator_id: ctx.user._id


https://github.com/airbnb/javascript?tab=readme-ov-file#commas--dangling

grunch · 2025-01-23T13:45:24Z

bot/modules/community/commands.js

@@ -233,7 +233,7 @@ exports.changeVisibility = async ctx => {
    if (!(await validateObjectId(ctx, id))) return;
    const community = await Community.findOne({
      _id: id,
-      creator_id: ctx.user._id,
+      creator_id: ctx.user._id


https://github.com/airbnb/javascript?tab=readme-ov-file#commas--dangling

grunch · 2025-01-23T13:47:02Z

jobs/check_solvers.ts

+
+    await bot.telegram.sendMessage(
+      admin.tg_id,
+      message


https://github.com/airbnb/javascript?tab=readme-ov-file#commas--dangling

knocte · 2025-01-23T13:47:47Z

as you can read in our contribution section, we are using the airbnb javascript guide style, please don't remove the comma

How about moving to a style that can be checked at CI time? e.g. with prettier

knocte · 2025-01-23T13:48:22Z

@webwarrior-ws hey, please check CI, it is red.

knocte · 2025-01-23T13:52:17Z

@webwarrior-ws hey, please check CI, it is red.

Oops wrong contributor!

grunch · 2025-01-23T13:52:58Z

as you can read in our contribution section, we are using the airbnb javascript guide style, please don't remove the comma

How about moving to a style that can be checked at CI time? e.g. with prettier

yes I have it locally but we need it at CI level

Anyitechs · 2025-01-23T14:09:40Z

Thank you for the review @grunch. I just addressed the feedbacks, rebased and updated the branch.

feat: notify admin to update solvers in the community

6ad31a8

Anyitechs mentioned this pull request Dec 20, 2024

Bot message to community admin to update solvers #314

Open

Catrya requested changes Dec 22, 2024

View reviewed changes

fix: notification messages not being sent to the admin and ensure mes…

9a547c9

…sages are localized

Catrya reviewed Jan 8, 2025

View reviewed changes

Catrya approved these changes Jan 9, 2025

View reviewed changes

Catrya reviewed Jan 10, 2025

View reviewed changes

Anyitechs force-pushed the update-solvers branch from eb20c72 to bf0258f Compare January 20, 2025 15:41

Catrya approved these changes Jan 20, 2025

View reviewed changes

grunch reviewed Jan 23, 2025

View reviewed changes

chore: improve admin notification message

1772689

Anyitechs force-pushed the update-solvers branch from bf0258f to 1772689 Compare January 23, 2025 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: notify admin to update solvers in the community #618

feat: notify admin to update solvers in the community #618

Anyitechs commented Dec 20, 2024

Catrya left a comment

Anyitechs commented Dec 22, 2024

Anyitechs commented Jan 3, 2025 •

edited

Loading

Catrya left a comment

Anyitechs commented Jan 9, 2025

Catrya left a comment

Catrya left a comment

Anyitechs commented Jan 20, 2025

Catrya commented Jan 20, 2025

Anyitechs commented Jan 20, 2025

Anyitechs commented Jan 20, 2025

Catrya left a comment

Anyitechs commented Jan 21, 2025 •

edited

Loading

grunch Jan 23, 2025

Anyitechs Jan 23, 2025

grunch Jan 23, 2025

grunch Jan 23, 2025 •

edited

Loading

grunch Jan 23, 2025

knocte commented Jan 23, 2025

knocte commented Jan 23, 2025

knocte commented Jan 23, 2025 •

edited

Loading

grunch commented Jan 23, 2025

Anyitechs commented Jan 23, 2025

feat: notify admin to update solvers in the community #618

Are you sure you want to change the base?

feat: notify admin to update solvers in the community #618

Conversation

Anyitechs commented Dec 20, 2024

Catrya left a comment

Choose a reason for hiding this comment

Anyitechs commented Dec 22, 2024

Anyitechs commented Jan 3, 2025 • edited Loading

Catrya left a comment

Choose a reason for hiding this comment

Anyitechs commented Jan 9, 2025

Catrya left a comment

Choose a reason for hiding this comment

Catrya left a comment

Choose a reason for hiding this comment

Anyitechs commented Jan 20, 2025

Catrya commented Jan 20, 2025

Anyitechs commented Jan 20, 2025

Anyitechs commented Jan 20, 2025

Catrya left a comment

Choose a reason for hiding this comment

Anyitechs commented Jan 21, 2025 • edited Loading

grunch Jan 23, 2025

Choose a reason for hiding this comment

Anyitechs Jan 23, 2025

Choose a reason for hiding this comment

grunch Jan 23, 2025

Choose a reason for hiding this comment

grunch Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

grunch Jan 23, 2025

Choose a reason for hiding this comment

knocte commented Jan 23, 2025

knocte commented Jan 23, 2025

knocte commented Jan 23, 2025 • edited Loading

grunch commented Jan 23, 2025

Anyitechs commented Jan 23, 2025

Anyitechs commented Jan 3, 2025 •

edited

Loading

Anyitechs commented Jan 21, 2025 •

edited

Loading

grunch Jan 23, 2025 •

edited

Loading

knocte commented Jan 23, 2025 •

edited

Loading